Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFixed #5933 #5964
Fixed #5933 #5964
Conversation
highfive
commented
May 6, 2015
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @metajack (or someone else) soon. |
hoppipolla-critic-bot
commented
May 6, 2015
|
Critic review: https://critic.hoppipolla.co.uk/r/4923 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
There's already an attempt to fix this in #5941, unfortunately, but it sounds like you could take it over and address some of the remaining discussion there. |
jinankjain commentedMay 6, 2015