Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #5933 #5964

Closed
wants to merge 1 commit into from
Closed

Fixed #5933 #5964

wants to merge 1 commit into from

Conversation

@jinankjain
Copy link

jinankjain commented May 6, 2015

Review on Reviewable

@highfive
Copy link

highfive commented May 6, 2015

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @metajack (or someone else) soon.

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented May 6, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4923

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@jdm
Copy link
Member

jdm commented May 6, 2015

There's already an attempt to fix this in #5941, unfortunately, but it sounds like you could take it over and address some of the remaining discussion there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.