Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upEmbedding: wooden bikeshed #5985
Conversation
highfive
commented
May 8, 2015
hoppipolla-critic-bot
commented
May 8, 2015
|
Critic review: https://critic.hoppipolla.co.uk/r/4939 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
…older fails to load now we just print a message and continue
|
Reviewed files:
ports/cef/Cargo.toml, line 88 [r2] (raw file): instead. We removed our dependency on the rust-x11 project. Comments from the review on Reviewable.io |
|
@larsbergstrom I'm actually advocating for moving from rust-xlib to x11-rs in #5566 :) |
|
@bors-servo: r+ |
|
|
Some small changes. @larsbergstrom or whoever cares the most at this exact moment. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5985) <!-- Reviewable:end -->
zmike commentedMay 8, 2015
Some small changes.
@larsbergstrom or whoever cares the most at this exact moment.