Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedding: wooden bikeshed #5985

Merged
merged 3 commits into from May 8, 2015
Merged

Conversation

@zmike
Copy link
Contributor

zmike commented May 8, 2015

Some small changes.

@larsbergstrom or whoever cares the most at this exact moment.

Review on Reviewable

Mike Blumenkrantz added 2 commits May 6, 2015
Mike Blumenkrantz
cef_get_xdisplay() was an internal function that should not have been used here
@highfive
Copy link

highfive commented May 8, 2015

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented May 8, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4939

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

…older fails to load

now we just print a message and continue
@larsbergstrom
Copy link
Contributor

larsbergstrom commented May 8, 2015

Reviewed files:

  • components/net/image_cache_task.rs @ r3
  • ports/cef/Cargo.lock @ r2
  • ports/cef/Cargo.toml @ r2
  • ports/cef/eutil.rs @ r1
  • ports/cef/window.rs @ r2

ports/cef/Cargo.toml, line 88 [r2] (raw file):
Please pick up the XOpenDisplay binding from:
./git/checkouts/rust-layers-3d9d5f0b4e4d9002/master/Cargo.toml:[dependencies.xlib]
./git/checkouts/rust-layers-3d9d5f0b4e4d9002/master/Cargo.toml:git = "https://github.com/servo/rust-xlib"

instead. We removed our dependency on the rust-x11 project.


Comments from the review on Reviewable.io

@larsbergstrom larsbergstrom self-assigned this May 8, 2015
@jdm
Copy link
Member

jdm commented May 8, 2015

@larsbergstrom I'm actually advocating for moving from rust-xlib to x11-rs in #5566 :)

@larsbergstrom
Copy link
Contributor

larsbergstrom commented May 8, 2015

@bors-servo
Copy link
Contributor

bors-servo commented May 8, 2015

📌 Commit f588c0b has been approved by larsbergstrom

@bors-servo
Copy link
Contributor

bors-servo commented May 8, 2015

Testing commit f588c0b with merge 892a740...

bors-servo pushed a commit that referenced this pull request May 8, 2015
Some small changes.

@larsbergstrom or whoever cares the most at this exact moment.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5985)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 8, 2015

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2

@bors-servo bors-servo merged commit f588c0b into servo:master May 8, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.