Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script: Implement the `color` attribute of the `<font>` element. #5989

Merged
merged 1 commit into from May 20, 2015
Merged

script: Implement the `color` attribute of the `<font>` element. #5989

merged 1 commit into from May 20, 2015

Conversation

@pcwalton
Copy link
Contributor

pcwalton commented May 8, 2015

Improves Hacker News.

r? @Ms2ger

Review on Reviewable
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented May 8, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4942

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@bors-servo
Copy link
Contributor

bors-servo commented May 12, 2015

☔ The latest upstream changes (presumably #5988) made this pull request unmergeable. Please resolve the merge conflicts.
@pcwalton pcwalton force-pushed the pcwalton:font-color branch from 36f6caa to df764ec May 19, 2015
@pcwalton
Copy link
Contributor Author

pcwalton commented May 19, 2015

Comments addressed and rebased. r? @jdm
@jdm
Copy link
Member

jdm commented May 19, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2015

📌 Commit df764ec has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2015

⌛ Testing commit df764ec with merge fa71ad0...
bors-servo pushed a commit that referenced this pull request May 19, 2015
bors-servo
Auto merge of #5989 - pcwalton:font-color, r=jdm
fa71ad0 
Improves Hacker News.

r? @Ms2ger

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5989)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2015

💔 Test failed - mac1
@pcwalton
script: Implement the `color` attribute of the `<font>` element.
Loading status checks…
7d9eda9 
Improves Hacker News.
@pcwalton pcwalton force-pushed the pcwalton:font-color branch from df764ec to 7d9eda9 May 19, 2015
@pcwalton
Copy link
Contributor Author

pcwalton commented May 19, 2015

@bors-servo: r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2015

📌 Commit 7d9eda9 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2015

⌛ Testing commit 7d9eda9 with merge ba340ec...
bors-servo pushed a commit that referenced this pull request May 19, 2015
bors-servo
Auto merge of #5989 - pcwalton:font-color, r=jdm
Loading status checks…
ba340ec 
Improves Hacker News.

r? @Ms2ger

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5989)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 20, 2015

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2
@bors-servo bors-servo merged commit 7d9eda9 into servo:master May 20, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request May 20, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Ms2ger Ms2ger

Labels
S-awaiting-review
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@pcwalton @hoppipolla-critic-bot @bors-servo @jdm @Ms2ger @highfive
You can’t perform that action at this time.