Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add parent window setting when creating windows with glutin #5995

Merged
merged 2 commits into from May 13, 2015
Merged

add parent window setting when creating windows with glutin #5995

merged 2 commits into from May 13, 2015

Conversation

@zmike
Copy link
Contributor

zmike commented May 9, 2015

needed for embedding api usage

Depends on servo/glutin#20

Review on Reviewable
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented May 9, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4952

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@zmike zmike force-pushed the zmike:glutin-parenting branch from b4c8f45 to 46e7418 May 12, 2015
@larsbergstrom
Copy link
Contributor

larsbergstrom commented May 12, 2015

Reviewed files:

  • components/servo/main.rs @ r1
  • ports/cef/browser.rs @ r1
  • ports/glutin/lib.rs @ r1
  • ports/glutin/window.rs @ r1

Comments from the review on Reviewable.io
@larsbergstrom
Copy link
Contributor

larsbergstrom commented May 12, 2015

Needs an update to the new glutin dependency version.
@zmike
Copy link
Contributor Author

zmike commented May 12, 2015

Updated
@zmike zmike mentioned this pull request May 12, 2015
Merged
@larsbergstrom
Copy link
Contributor

larsbergstrom commented May 13, 2015

Reviewed files:

  • components/servo/Cargo.lock @ r2
  • ports/cef/Cargo.lock @ r2

Comments from the review on Reviewable.io
@larsbergstrom
Copy link
Contributor

larsbergstrom commented May 13, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented May 13, 2015

📌 Commit 532c8c3 has been approved by larsbergstrom
@bors-servo
Copy link
Contributor

bors-servo commented May 13, 2015

⌛ Testing commit 532c8c3 with merge ba7fb63...
@bors-servo
Copy link
Contributor

bors-servo commented May 13, 2015

💔 Test failed - linux2
@zmike
Copy link
Contributor Author

zmike commented May 13, 2015

I don't understand why this failed.
@jdm
Copy link
Member

jdm commented May 13, 2015

The headless configuration wasn't updated: https://github.com/zmike/servo/blob/glutin-parenting/ports/glutin/window.rs#L618
Mike Blumenkrantz added 2 commits May 9, 2015
Mike Blumenkrantz
add parent window setting when creating windows with glutin
16a9712 
needed for embedding api usage
Mike Blumenkrantz
bump glutin version for cargo
Loading status checks…
d2133b2
@zmike zmike force-pushed the zmike:glutin-parenting branch from 532c8c3 to d2133b2 May 13, 2015
@zmike
Copy link
Contributor Author

zmike commented May 13, 2015

Aha! Updated
@jdm
Copy link
Member

jdm commented May 13, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented May 13, 2015

📌 Commit d2133b2 has been approved by jdm
bors-servo pushed a commit that referenced this pull request May 13, 2015
bors-servo
Auto merge of #5995 - zmike:glutin-parenting, r=jdm
683c093 
needed for embedding api usage

Depends on servo/glutin#20

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5995)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 13, 2015

⌛ Testing commit d2133b2 with merge 683c093...
@bors-servo
Copy link
Contributor

bors-servo commented May 13, 2015

💔 Test failed - linux2
@jdm
Copy link
Member

jdm commented May 13, 2015

@bors-servo: retry
bors-servo pushed a commit that referenced this pull request May 13, 2015
bors-servo
Auto merge of #5995 - zmike:glutin-parenting, r=jdm
Loading status checks…
a388a76 
needed for embedding api usage

Depends on servo/glutin#20

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5995)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 13, 2015

⌛ Testing commit d2133b2 with merge a388a76...
@bors-servo
Copy link
Contributor

bors-servo commented May 13, 2015

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2
@bors-servo bors-servo merged commit d2133b2 into servo:master May 13, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@zmike @hoppipolla-critic-bot @larsbergstrom @bors-servo @jdm @highfive
You can’t perform that action at this time.