Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More cleanup of the servo entry points #6010

Merged
merged 10 commits into from May 12, 2015
Merged

More cleanup of the servo entry points #6010

merged 10 commits into from May 12, 2015
+41 −198

Conversation

@brson
Copy link
Contributor

brson commented May 11, 2015

Just cleanup.

Review on Reviewable
brson added 10 commits May 9, 2015
@brson
Remove bogus comment
23a20e9
@brson
Whitespace
dd04cf4
@brson
Remove call to env::current_dir from Browser
aa906a5 
Put it in util::opts instead.
@brson
Add some overview docs to compositing::constellation
17747ad
@brson
Add an assert to opts::set_opts.
8975a3b 
This function leaks if called more than once.
@brson
util: Rename `ops::set_opts` to `ops::set`, to match `get`
f8bbc0a
@brson
util: Set the experimental_enabled flag when options are set
df9c132
@brson
Check in new Cargo.lock for cef
d1b0a4b
@brson
Fix gonk port
bc28469
@brson
Remove lib.rs from gonk port. Unused
Loading status checks…
a0d14ac
@pcwalton
Copy link
Contributor

pcwalton commented May 11, 2015

Looks good to me, but maybe @michaelwu should take a look too.
@michaelwu
Copy link
Contributor

michaelwu commented May 11, 2015

Don't worry about the gonk port - it's too late for that. The port was broken when webgl was landed. If I need that file back I can just restore it when I get back to fixing that port.
@pcwalton
Copy link
Contributor

pcwalton commented May 11, 2015

Looks good then, feel free to squash.
@Ms2ger
Copy link
Contributor

Ms2ger commented May 12, 2015

@bors-servo: r=pcwalton
@bors-servo
Copy link
Contributor

bors-servo commented May 12, 2015

📌 Commit a0d14ac has been approved by pcwalton
@bors-servo
Copy link
Contributor

bors-servo commented May 12, 2015

⌛ Testing commit a0d14ac with merge ca9c703...
bors-servo pushed a commit that referenced this pull request May 12, 2015
bors-servo
Auto merge of #6010 - brson:next, r=pcwalton
Loading status checks…
ca9c703 
Just cleanup.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6010)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 12, 2015

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2
@bors-servo bors-servo merged commit a0d14ac into servo:master May 12, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
This was referenced May 12, 2015
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-review
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@brson @pcwalton @michaelwu @Ms2ger @bors-servo @highfive
You can’t perform that action at this time.