Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HTMLSelectElement.{multiple, name, size} (fixes #6017) #6018

Merged
merged 1 commit into from May 12, 2015

Conversation

@Jinwoo-Song
Copy link
Contributor

Jinwoo-Song commented May 12, 2015

r? @jdm
cc @yichoi

Review on Reviewable

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented May 12, 2015

Critic review: https://critic.hoppipolla.co.uk/r/4973

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@Ms2ger
Copy link
Contributor

Ms2ger commented May 12, 2015

@bors-servo
Copy link
Contributor

bors-servo commented May 12, 2015

📌 Commit 656a8ee has been approved by Ms2ger

@bors-servo
Copy link
Contributor

bors-servo commented May 12, 2015

Testing commit 656a8ee with merge 396a0de...

bors-servo pushed a commit that referenced this pull request May 12, 2015
r? @jdm 
cc @yichoi

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6018)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 12, 2015

💔 Test failed - mac2

@Jinwoo-Song
Copy link
Contributor Author

Jinwoo-Song commented May 12, 2015

The failing test case seems not to be related to this patch. :( What should I do?

failures:

---- hide_after_create.html == hide_after_create_ref.html stdout ----
thread 'hide_after_create.html == hide_after_create_ref.html' panicked at 'rendering difference: /tmp/servo-reftest-000096-diff.png', ../../tests/reftest.rs:335

stack backtrace:
1: 0x101896bef - sys::backtrace::write::h6990067d88907b48zVr
2: 0x10189aca0 - panicking::on_panic::he976cdbadffd9e1bEVv
3: 0x10187bde5 - rt::unwind::begin_unwind_inner::ha519446d83876aa8nDv
4: 0x10187c57c - rt::unwind::begin_unwind_fmt::h15c2d4adf8e8ecdatCv
5: 0x101810904 - check_reftest::h50e372ab33546d9fiKa
6: 0x10180fbc6 - make_test::closure.6451
7: 0x101810a8c - boxed::F.FnBox::call_box::h4518433956128595388
8: 0x10183b34f - boxed::F.FnBox::call_box::h17736871663463343674
9: 0x101838937 - rt::unwind::try::try_fn::h1582047561577903298
10: 0x10189cd28 - rust_try_inner
11: 0x10189cd15 - rust_try
12: 0x101838c1e - boxed::F.FnBox::call_box::h18004624870484171567
13: 0x10189975d - sys:🧵:Thread:🆕:thread_start::h5fcf8fe12ec3c274mYu
14: 0x7fff85a40771 - _pthread_start

failures:
hide_after_create.html == hide_after_create_ref.html

@Ms2ger
Copy link
Contributor

Ms2ger commented May 12, 2015

@bors-servo
Copy link
Contributor

bors-servo commented May 12, 2015

Testing commit 656a8ee with merge f4381a6...

bors-servo pushed a commit that referenced this pull request May 12, 2015
r? @jdm 
cc @yichoi

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6018)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 12, 2015

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2

@bors-servo bors-servo mentioned this pull request May 12, 2015
@bors-servo bors-servo merged commit 656a8ee into servo:master May 12, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.