Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement HTMLSelectElement.{multiple, name, size} (fixes #6017) #6018
Conversation
hoppipolla-critic-bot
commented
May 12, 2015
|
Critic review: https://critic.hoppipolla.co.uk/r/4973 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
@bors-servo: r+ |
|
|
r? @jdm cc @yichoi <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6018) <!-- Reviewable:end -->
|
|
|
The failing test case seems not to be related to this patch. :( What should I do? failures: ---- hide_after_create.html == hide_after_create_ref.html stdout ---- stack backtrace: failures: |
|
@bors-servo: retry |
r? @jdm cc @yichoi <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6018) <!-- Reviewable:end -->
Jinwoo-Song commentedMay 12, 2015
r? @jdm
cc @yichoi