Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the presentational hint from table border to the new infrastructure. #6019

Merged
merged 4 commits into from May 12, 2015
Merged

Move the presentational hint from table border to the new infrastructure. #6019

merged 4 commits into from May 12, 2015

Conversation

Ms2ger
Copy link
Contributor

@Ms2ger Ms2ger commented May 12, 2015

Review on Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label May 12, 2015
@highfive
Copy link

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/4974

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@Ms2ger
Copy link
Contributor Author

Ms2ger commented May 12, 2015

r? @pcwalton

@pcwalton
Copy link
Contributor

@bors-servo: r+

@bors-servo
Copy link
Contributor

📌 Commit 69f9259 has been approved by pcwalton

@bors-servo
Copy link
Contributor

⌛ Testing commit 69f9259 with merge 398e7f0...

bors-servo pushed a commit that referenced this pull request May 12, 2015
Auto merge of #6019 - Ms2ger:preshint-border, r=pcwalton
398e7f0 
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6019)
<!-- Reviewable:end -->
@jdm jdm added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels May 12, 2015
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2

@bors-servo bors-servo merged commit 69f9259 into servo:master May 12, 2015
@Ms2ger Ms2ger deleted the preshint-border branch May 17, 2015 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pcwalton pcwalton

Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Ms2ger @highfive @hoppipolla-critic-bot @pcwalton @bors-servo @jdm