Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSanitise web fonts #6030
Closed
Sanitise web fonts #6030
Conversation
hoppipolla-critic-bot
commented
May 13, 2015
|
Critic review: https://critic.hoppipolla.co.uk/r/4983 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
Both this and servo/fontsan seem reasonable. @bors-servo: r+ |
|
|
|
@bors-servo: r+ |
|
|
bors-servo
pushed a commit
that referenced
this pull request
May 13, 2015
Fixes #3030. r? @pcwalton. If you can take a look at [the fontsan repo](https://github.com/servo/fontsan) as well, that'd be great. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6030) <!-- Reviewable:end -->
|
|
This will need a README.md and https://github.com/servo/saltfs/ change. |
jdm
added
S-blocked-on-external
S-needs-code-changes
and removed
S-awaiting-review
labels
|
Surely we already have at least one copy of |
|
I modified fontsan to use the libz-sys crate. |
|
@bors-servo: r=pcwalton |
|
|
bors-servo
pushed a commit
that referenced
this pull request
May 14, 2015
Fixes #3030. r? @pcwalton. If you can take a look at [the fontsan repo](https://github.com/servo/fontsan) as well, that'd be great. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6030) <!-- Reviewable:end -->
|
|
|
jdm
added
S-needs-code-changes
and removed
S-awaiting-review
S-blocked-on-external
labels
|
Maybe I'll modify it to use miniz since we already build and link that. |
|
@bors-servo: r=pcwalton |
|
|
bors-servo
pushed a commit
that referenced
this pull request
May 15, 2015
Fixes #3030. r? @pcwalton. If you can take a look at [the fontsan repo](https://github.com/servo/fontsan) as well, that'd be great. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6030) <!-- Reviewable:end -->
|
|
|
|
@bors-servo: r=pcwalton |
|
|
|
|
bors-servo
pushed a commit
that referenced
this pull request
May 15, 2015
Fixes #3030. r? @pcwalton. If you can take a look at [the fontsan repo](https://github.com/servo/fontsan) as well, that'd be great. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6030) <!-- Reviewable:end -->
|
|
|
|
|
|
@kmc Let's try and get this landed this week. Let me know if you need help. |
|
@glennw Can you take this over? |
|
Superseded by #7634. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kmcallister commentedMay 13, 2015
Fixes #3030.
r? @pcwalton.
If you can take a look at the fontsan repo as well, that'd be great.