Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msttcorefonts is a requirement #605

Merged
merged 1 commit into from Jul 19, 2013
Merged

msttcorefonts is a requirement #605

merged 1 commit into from Jul 19, 2013

Conversation

@rfielding
Copy link
Contributor

rfielding commented Jul 19, 2013

assertion will fail if msttcorefonts is not installed. the page will come up successfuly now when literally following the README.md (a segfault when the window is closed, but good progress now).

build and make check will pass, but assertion will fail if msttcorefonts is not installed.
@metajack

This comment has been minimized.

Copy link

metajack commented on 03377ce Jul 19, 2013

r+

@metajack

This comment has been minimized.

Copy link
Contributor

metajack commented Jul 19, 2013

I was just about to add this myself after seeing your bug report. You rock!

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 03377ce Jul 19, 2013

saw approval from metajack
at rfielding@03377ce

This comment has been minimized.

Copy link
Contributor

bors-servo replied Jul 19, 2013

merging rfielding/servo/master = 03377ce into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Jul 19, 2013

rfielding/servo/master = 03377ce merged ok, testing candidate = d27b1a8

This comment has been minimized.

Copy link
Contributor

bors-servo replied Jul 19, 2013

fast-forwarding master to auto = d27b1a8

bors-servo pushed a commit that referenced this pull request Jul 19, 2013
assertion will fail if msttcorefonts is not installed.  the page will come up successfuly now  when literally following the README.md (a segfault when the window is closed, but good progress now).
@bors-servo bors-servo merged commit 03377ce into servo:master Jul 19, 2013
1 check passed
1 check passed
default all tests passed
glennw pushed a commit to glennw/servo that referenced this pull request Jan 16, 2017
Add more control over when and how to clear the framebuffer.

This pull request addresses issue servo#601. The RendererOptions now specify a default clear color for the main framebuffer (intermediate targets are cleared with transparent black in any case), an option to always clear using the device's clear function, and a separate option to use the clear shader for empty tiles (previously referred to as "clear tiles"). Note that the clear shader ignores the clear color and always uses opaque white.

I don't know if we want to keep the clear shader around, I am pretty sure it is currently never used because of the enforced background rectangle in frame.rs. If we want to get rid of it, I can add that to the PR (I don't know if we'd keep the information about empty tiles or not, probably should?), or we can leave it and decide later.

Edit: Removed confusion about non-root pipelines.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/605)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.