Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upmsttcorefonts is a requirement #605
Merged
Conversation
build and make check will pass, but assertion will fail if msttcorefonts is not installed.
This comment has been minimized.
This comment has been minimized.
metajack
commented on 03377ce
Jul 19, 2013
|
r+ |
|
I was just about to add this myself after seeing your bug report. You rock! |
This comment has been minimized.
This comment has been minimized.
|
saw approval from metajack |
This comment has been minimized.
This comment has been minimized.
|
merging rfielding/servo/master = 03377ce into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = d27b1a8 |
bors-servo
pushed a commit
that referenced
this pull request
Jul 19, 2013
assertion will fail if msttcorefonts is not installed. the page will come up successfuly now when literally following the README.md (a segfault when the window is closed, but good progress now).
bors-servo
merged commit 03377ce
into
servo:master
1 check passed
1 check passed
default
all tests passed
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
Add more control over when and how to clear the framebuffer. This pull request addresses issue servo#601. The RendererOptions now specify a default clear color for the main framebuffer (intermediate targets are cleared with transparent black in any case), an option to always clear using the device's clear function, and a separate option to use the clear shader for empty tiles (previously referred to as "clear tiles"). Note that the clear shader ignores the clear color and always uses opaque white. I don't know if we want to keep the clear shader around, I am pretty sure it is currently never used because of the enforced background rectangle in frame.rs. If we want to get rid of it, I can add that to the PR (I don't know if we'd keep the information about empty tiles or not, probably should?), or we can leave it and decide later. Edit: Removed confusion about non-root pipelines. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/605) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
rfielding commentedJul 19, 2013
assertion will fail if msttcorefonts is not installed. the page will come up successfuly now when literally following the README.md (a segfault when the window is closed, but good progress now).