Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix broken inline CSS #606
Merged
Conversation
If '\r' appears in an inline <style> element, libhubbub splits the text nodes there, creating multiple text children. The inline style logic assumed that each <style> element had only one child. The logic was moved to trigger when the style element is finished parsing completely (including the children), and then the children are concatenated before sending it to the parser.
This comment has been minimized.
This comment has been minimized.
jdm
commented on src/components/script/html/hubbub_html_parser.rs in 34106d7
Jul 19, 2013
|
This whitespace can go. |
This comment has been minimized.
This comment has been minimized.
|
Whoops! |
This comment has been minimized.
This comment has been minimized.
jdm
commented on 2b44efb
Jul 19, 2013
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from jdm |
This comment has been minimized.
This comment has been minimized.
|
merging metajack/servo/broken-inline-css = 2b44efb into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = cca33c2 |
bors-servo
pushed a commit
that referenced
this pull request
Jul 19, 2013
This add a new children iterator to abstract node and fixes a bug where inline stylesheets got parsed piecewise due to \r style line endings.
bors-servo
merged commit 2b44efb
into
servo:master
1 check passed
1 check passed
default
all tests passed
Merged
bors-servo
pushed a commit
that referenced
this pull request
Jul 20, 2013
ChrisParis
pushed a commit
to ChrisParis/servo
that referenced
this pull request
Sep 7, 2014
Deleted some old tests from Infraware on forms that are better handled in tests we already had from Aryeh. Kept the ones we didn't yet have corresponding tests for from Aryeh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
metajack commentedJul 19, 2013
This add a new children iterator to abstract node and fixes a bug where inline stylesheets got parsed piecewise due to \r style line endings.