Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue #6073 #6084

Merged
merged 2 commits into from May 20, 2015
Merged

Fix for Issue #6073 #6084

merged 2 commits into from May 20, 2015

Conversation

@WriterOfAlicrow
Copy link
Contributor

WriterOfAlicrow commented May 16, 2015

Review on Reviewable
@WriterOfAlicrow
Fix for Issue #6073
Loading status checks…
85c88c7
@highfive
Copy link

highfive commented May 16, 2015

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @larsbergstrom (or someone else) soon.
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented May 16, 2015

Critic review: https://critic.hoppipolla.co.uk/r/5023

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@WriterOfAlicrow
fixup! Fix for Issue #6073
Loading status checks…
11a4aac
@larsbergstrom
Copy link
Contributor

larsbergstrom commented May 19, 2015

@Manishearth @jdm does this look like a good fix?
@jdm
Copy link
Member

jdm commented May 19, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2015

📌 Commit 11a4aac has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2015

⌛ Testing commit 11a4aac with merge 588f2e0...
bors-servo pushed a commit that referenced this pull request May 19, 2015
bors-servo
Auto merge of #6084 - WriterOfAlicrow:radiobutton-fix, r=jdm
588f2e0 
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6084)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2015

💔 Test failed - linux2
@jdm
Copy link
Member

jdm commented May 20, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented May 20, 2015

⌛ Testing commit 11a4aac with merge e2b0922...
bors-servo pushed a commit that referenced this pull request May 20, 2015
bors-servo
Auto merge of #6084 - WriterOfAlicrow:radiobutton-fix, r=jdm
Loading status checks…
e2b0922 
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6084)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 20, 2015

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2
@bors-servo bors-servo merged commit 11a4aac into servo:master May 20, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@WriterOfAlicrow @highfive @hoppipolla-critic-bot @larsbergstrom @jdm @bors-servo
You can’t perform that action at this time.