Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position float children relative to their parent #612

Merged
merged 2 commits into from Jul 22, 2013

Conversation

@metajack
Copy link
Contributor

metajack commented Jul 22, 2013

They were being positioned outside their parent's box in some cases.

metajack added 2 commits Jul 22, 2013
Nested `debug!()` calls are no-ops, so change it now does a `println`. Also
moved to the `debug!()` calls out of the profiled block.
@jdm

This comment has been minimized.

Copy link

jdm commented on 82765c2 Jul 22, 2013

r+

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented on 82765c2 Jul 22, 2013

saw approval from jdm
at metajack@82765c2

This comment has been minimized.

Copy link
Contributor

bors-servo replied Jul 22, 2013

merging metajack/servo/float-children = 82765c2 into auto

This comment has been minimized.

Copy link
Contributor

bors-servo replied Jul 22, 2013

metajack/servo/float-children = 82765c2 merged ok, testing candidate = 4f227e0

This comment has been minimized.

Copy link
Contributor

bors-servo replied Jul 22, 2013

fast-forwarding master to auto = 4f227e0

bors-servo pushed a commit that referenced this pull request Jul 22, 2013
They were being positioned outside their parent's box in some cases.
@bors-servo bors-servo merged commit 82765c2 into servo:master Jul 22, 2013
1 check passed
1 check passed
default all tests passed
ChrisParis pushed a commit to ChrisParis/servo that referenced this pull request Sep 7, 2014
Rewrite infraware tests on appcache
glennw pushed a commit to glennw/servo that referenced this pull request Jan 16, 2017
Support dynamic changes to device_pixel_ratio.

Ensures that the device pixel ratio isn't stored in any
structures permanently, and that any code that depends
on the value of the device pixel ratio is moved to sections
that are executed each render.

The idea is that the current device pixel ratio is stored
in the render backend, and this gets passed through the entire
pipeline each frame to the renderer.

In the future there will be an API provided to modify the
device pixel ratio, but for now it is still fixed to a single
value at init time.

This is prep work for supporting functionality such as zoom, and
moving the window between monitors with different device pixel ratios.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/612)
<!-- Reviewable:end -->
@jdm jdm mentioned this pull request Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.