Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upThrow a SyntaxError if the WebSocket URL can't be parsed. Fix #6061 #6127
Conversation
highfive
commented
May 18, 2015
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @SimonSapin (or someone else) soon. |
hoppipolla-critic-bot
commented
May 18, 2015
|
Critic review: https://critic.hoppipolla.co.uk/r/5043 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
Reviewed on critic (though I need to have another look at |
|
Looks good! Please squash the commits, and this will be good to go. I’ve also edited your PR message to include "Fix #6061" (rather than just the number) so that GitHub will close the issue automatically when this is merged. |
836c62f
to
d7387ed
|
Should the S-needs-squash tag get cleared automatically or did I make a mistake? |
|
I don’t think our automation is that good yet. But what did you change? I still see 7 commits. |
d7387ed
to
51ae733
|
@bors-servo: r=Ms2ger |
|
|
|
I was doing the rebasing incorrectly. I was passing --autosquash without --interactive. |
Fix #6061. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6127) <!-- Reviewable:end -->
Nashenas88 commentedMay 18, 2015
Fix #6061.