Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix several hangs / panics during pipeline cleanup of in progress loads. #6131

Merged
merged 4 commits into from May 20, 2015

Conversation

@glennw
Copy link
Member

glennw commented May 19, 2015

This fixes a hang found while testing the jQuery test suite.

Review on Reviewable

This fixes a hang found while testing the jQuery test suite.
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented May 19, 2015

Critic review: https://critic.hoppipolla.co.uk/r/5047

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@glennw
Copy link
Member Author

glennw commented May 19, 2015

@jdm
Copy link
Member

jdm commented May 19, 2015

-S-awaiting-review +S-needs-code-changes


Review status: all files reviewed, 2 unresolved discussions, all commit checks successful.
Reviewed files:

  • components/compositing/compositor_task.rs @ r1
  • components/gfx/paint_task.rs @ r1
  • components/layout/layout_task.rs @ r1
  • components/msg/constellation_msg.rs @ r1
  • components/script/dom/window.rs @ r1
  • components/script/script_task.rs @ r1
  • components/util/task.rs @ r1

components/script/script_task.rs, line 1089 [r1] (raw file):
This comment's position is misleading now.


components/script/script_task.rs, line 1097 [r1] (raw file):
This is not necessarily the root.


Comments from the review on Reviewable.io

@glennw
Copy link
Member Author

glennw commented May 19, 2015

Review status: 6 of 7 files reviewed, 2 unresolved discussions, all commit checks successful.


components/script/script_task.rs, line 1089 [r1] (raw file):
Done.


components/script/script_task.rs, line 1097 [r1] (raw file):
Done.


Comments from the review on Reviewable.io

@jdm
Copy link
Member

jdm commented May 20, 2015

@bors-servo: r+
-S-awaiting-review +S-awaiting-merge


Review status: :shipit: all files reviewed, all discussions resolved, all commit checks successful.
Reviewed files:

  • components/script/script_task.rs @ r4

Comments from the review on Reviewable.io

@bors-servo
Copy link
Contributor

bors-servo commented May 20, 2015

📌 Commit 41c243e has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented May 20, 2015

Testing commit 41c243e with merge c51e9f0...

bors-servo pushed a commit that referenced this pull request May 20, 2015
This fixes a hang found while testing the jQuery test suite.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6131)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 20, 2015

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2

@bors-servo bors-servo merged commit 41c243e into servo:master May 20, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@glennw glennw deleted the glennw:jquery-exit-fix branch Jul 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.