Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix calculation of float height and width. #614
Merged
Conversation
We were overshooting on height by including margins, and undershooting on width by not including margins, borders, and padding.
This comment has been minimized.
This comment has been minimized.
pcwalton
commented on 7e57b88
Jul 23, 2013
|
r+ |
This comment has been minimized.
This comment has been minimized.
|
saw approval from pcwalton |
This comment has been minimized.
This comment has been minimized.
|
merging metajack/servo/float-height-width = 7e57b88 into auto |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
fast-forwarding master to auto = b94a5ab |
bors-servo
pushed a commit
that referenced
this pull request
Jul 23, 2013
We were overshooting on height by including margins, and undershooting on width by not including margins, borders, and padding.
bors-servo
merged commit 7e57b88
into
servo:master
1 check passed
1 check passed
default
all tests passed
ChrisParis
pushed a commit
to ChrisParis/servo
that referenced
this pull request
Sep 7, 2014
Add tests for non-support of FileError and FileException.
glennw
pushed a commit
to glennw/servo
that referenced
this pull request
Jan 16, 2017
Fixed and improved the GPU markers Fixes servo#613 <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/614) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
metajack commentedJul 23, 2013
We were overshooting on height by including margins, and undershooting on
width by not including margins, borders, and padding.