Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Spidermonkey 39 #6141

Closed
wants to merge 7 commits into from
Prev

Disable incremental GC

The usual approach to supporting incremental barriers doesn't seem to work
when the pointer to the reflector is owned by the reflector.
  • Loading branch information
michaelwu committed May 20, 2015
commit bad5a84bd05e0f18d336d2f941fcaf9646e20550
@@ -75,7 +75,7 @@ use util::task_state;
use geom::Rect;
use geom::point::Point2D;
use hyper::header::{LastModified, Headers};
use js::jsapi::{JS_SetWrapObjectCallbacks, JS_AddExtraGCRootsTracer};
use js::jsapi::{JS_SetWrapObjectCallbacks, JS_AddExtraGCRootsTracer, DisableIncrementalGC};
use js::jsapi::{JSContext, JSRuntime, JSTracer, JSWrapObjectCallbacks};
use js::jsapi::{JS_SetGCCallback, JSGCStatus, JSAutoRequest};
use js::jsapi::{SetDOMProxyInformation, DOMProxyShadowsResult, HandleObject, HandleId, RootedValue};
@@ -519,6 +519,8 @@ impl ScriptTask {

unsafe {
SetDOMProxyInformation(ptr::null(), 0, Some(shadow_check_callback));
// Pre barriers aren't working correctly at the moment
DisableIncrementalGC(runtime.rt());
}

runtime
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.