Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rust to 716f920b7e234b450f272346fea961832505c06e #6151

Merged
merged 1 commit into from May 21, 2015
Merged

Upgrade rust to 716f920b7e234b450f272346fea961832505c06e #6151

merged 1 commit into from May 21, 2015

Conversation

@mbrubeck
Copy link
Contributor

mbrubeck commented May 20, 2015

(Tue May 19 05:39:29 2015 +0000)

Review on Reviewable
@Manishearth @mbrubeck
Upgrade rust to 716f920b7e234b450f272346fea961832505c06e (Tue May 19 …
Loading status checks…
4bc9445 
…05:39:29 2015 +0000)
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented May 20, 2015

Critic review: https://critic.hoppipolla.co.uk/r/5065

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@mbrubeck mbrubeck mentioned this pull request May 20, 2015
Closed
@mbrubeck
Copy link
Contributor Author

mbrubeck commented May 20, 2015

Review status: 3 of 7 files reviewed, all discussions resolved, all commit checks successful.
Reviewed files:

  • components/plugins/jstraceable.rs @ r1
  • components/plugins/lib.rs @ r1
  • tests/reftest.rs @ r1

Comments from the review on Reviewable.io
@larsbergstrom
Copy link
Contributor

larsbergstrom commented May 20, 2015

Review status: 4 of 7 files reviewed, all discussions resolved, all commit checks successful.
Reviewed files:

  • rust-snapshot-hash @ r1

Comments from the review on Reviewable.io
@larsbergstrom
Copy link
Contributor

larsbergstrom commented May 20, 2015

Review status: :shipit: all files reviewed, all discussions resolved, all commit checks successful.
Reviewed files:

  • components/servo/Cargo.lock @ r1
  • ports/cef/Cargo.lock @ r1
  • ports/gonk/Cargo.lock @ r1

Comments from the review on Reviewable.io
@larsbergstrom
Copy link
Contributor

larsbergstrom commented May 20, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented May 20, 2015

📌 Commit 4bc9445 has been approved by larsbergstrom
@bors-servo
Copy link
Contributor

bors-servo commented May 20, 2015

⌛ Testing commit 4bc9445 with merge 7ae5d11...
bors-servo pushed a commit that referenced this pull request May 20, 2015
bors-servo
Auto merge of #6151 - servo:rustup-2015_05_13, r=larsbergstrom
Loading status checks…
7ae5d11 
(Tue May 19 05:39:29 2015 +0000)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6151)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 21, 2015

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2
@bors-servo bors-servo merged commit 4bc9445 into master May 21, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the rustup-2015_05_13 branch May 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-review
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@mbrubeck @hoppipolla-critic-bot @larsbergstrom @bors-servo @highfive @Manishearth
You can’t perform that action at this time.