Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upChanges to improve the stability when running multiple tests with servodriver #6161
Conversation
hoppipolla-critic-bot
commented
May 22, 2015
|
Critic review: https://critic.hoppipolla.co.uk/r/5082 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
|
|
Assigning to @glennw. |
|
@jgraham squash, rebase and then r=me |
|
|
* Wait for the correct pipeline to return a LoadComplete message before signalling a load is complete, and ensure that the root pipeline is the one corresponding to the active document of the top level browsing context, even if this has not yet painted. * Ensure that TakeScreenshot operates on the correct pipeline * Reset the screenshot ready flag whenever we decide that we are ready to take a screenshot.
|
@bors-servo: r=glennw |
|
|
jdm
added
S-awaiting-merge
and removed
S-awaiting-review
S-needs-rebase
S-needs-squash
labels
This fixes various race conditions that affect test execution when using the servodriver product. It doesn't yet do enough to make servodriver a viable alternative to the normal servo test executor. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6161) <!-- Reviewable:end -->
jgraham commentedMay 22, 2015
This fixes various race conditions that affect test execution when using the servodriver product. It doesn't yet do enough to make servodriver a viable alternative to the normal servo test executor.