Changes to improve the stability when running multiple tests with servodriver #6161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
highfive
added
the
S-awaiting-review
|
Critic review: https://critic.hoppipolla.co.uk/r/5082 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
☔ The latest upstream changes (presumably #6175) made this pull request unmergeable. Please resolve the merge conflicts. |
jgraham
force-pushed
the
webdriver_stability
branch
from
c818209
to
e7f6e7b
Compare
|
Assigning to @glennw. |
glennw
added
S-needs-squash
|
@jgraham squash, rebase and then r=me |
jgraham
force-pushed
the
webdriver_stability
branch
from
e7f6e7b
to
81ac0b5
Compare
|
☔ The latest upstream changes (presumably #6246) made this pull request unmergeable. Please resolve the merge conflicts. |
* Wait for the correct pipeline to return a LoadComplete message before signalling a load is complete, and ensure that the root pipeline is the one corresponding to the active document of the top level browsing context, even if this has not yet painted. * Ensure that TakeScreenshot operates on the correct pipeline * Reset the screenshot ready flag whenever we decide that we are ready to take a screenshot.
jgraham
force-pushed
the
webdriver_stability
branch
from
81ac0b5
to
aa0f7a7
Compare
|
@bors-servo: r=glennw |
|
📌 Commit aa0f7a7 has been approved by |
jdm
added
S-awaiting-merge
bors-servo
pushed a commit
that referenced
this pull request
Jun 3, 2015
This fixes various race conditions that affect test execution when using the servodriver product. It doesn't yet do enough to make servodriver a viable alternative to the normal servo test executor. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6161) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes various race conditions that affect test execution when using the servodriver product. It doesn't yet do enough to make servodriver a viable alternative to the normal servo test executor.