fixes 4184: no-sniff and check-for-apache-bug for mime sniffing

[eleweek]

I tried fixing #4184 , here is the code I have right now.

I haven't tested it, because I don't know what is the best way to test this part of code. Would like some help with testing this. Should I write an autotest or should I just test manually?

[highfive]

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Ms2ger (or someone else) soon.

[hoppipolla-critic-bot]

Critic review: https://critic.hoppipolla.co.uk/r/5090

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

[Manishearth]

what if len() is zero?

[Manishearth]

Review status: all files reviewed, 3 unresolved discussions, all commit checks successful.
Reviewed files:

• components/net/resource_task.rs @ r1

---

^{components/net/resource_task.rs, line 113 [r1] (raw file):}
Shouldn't this be X-content-type-options?

---

^{components/net/resource_task.rs, line 115 [r1] (raw file):}
Nit: nosniff = raw_blah.iter().any(|ref opt| opt == b"nosniff") is more idiomatic.

---

Comments from the review on Reviewable.io

[Manishearth]

Filed web-platform-tests/wpt#1851 for the tests

[jdm]

In terms of automated tests, there's the fetch/nosniff directory in WPT. These can be enabled by adding the dir to http://mxr.mozilla.org/servo/source/tests/wpt/include.ini and run via ./mach test-wpt /fetch/nosniff/, but we don't enable MIME sniffing by default right now so they'll still fail. You could switch that in http://mxr.mozilla.org/servo/source/components/util/opts.rs#405 of course, but I don't think we actually want to turn it on by default right now.

[eleweek]

I updated the PR, I tested the code manually(both flags are set correctly). According to the discussion above there are things that needs to be done before enabling automatic testing, so I didn't do anything about this.

[Manishearth]

Review status: all files reviewed, all discussions resolved, all commit checks successful.
Reviewed files:

• components/net/resource_task.rs @ r2

---

Comments from the review on Reviewable.io

[Manishearth]

@bors-servo: r+

thanks!

[bors-servo]

📌 Commit f5a0285 has been approved by Manishearth

[bors-servo]

⌛ Testing commit f5a0285 with merge be6c251...

[bors-servo]

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2