Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAssorted SpiderMonkey GC-related fixes #6180
Conversation
highfive
commented
May 25, 2015
hoppipolla-critic-bot
commented
May 25, 2015
|
Critic review: https://critic.hoppipolla.co.uk/r/5096 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
@glennw These changes made the jQuery test suite hum along without incident for me. |
|
@jdm Fantastic! Thank you for looking into it! :) |
|
If #6150 can also run the jQuery test suite, I would prefer avoiding these changes. RootedVecs are fixed a bit differently and the issue with the global is part of a deeper issue that affects all dom objects being created/wrapped. The dom object being wrapped needs to be rooted while the wrapper is being setup because the dom object might point to other dom objects that aren't rooted. |
|
So when is |
|
@Ms2ger AFAIK, in the loop over dom_collections in RootedCollectionSet::trace(). |
|
If we're going to do this, I'd like to split up |
|
Please rebase on master. |
|
JS upgrade landed. Is any of this still useful? |
|
I suspect no. |
jdm commentedMay 25, 2015
These changes combined allow running a debug-mozjs Servo build with JS_GCZEAL=2,20 (ie. perform a GC every 20 allocations).
r? @Ms2ger