Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement Msg::Status with serialized url upon mouseover #6181
Conversation
|
Hooray! |
|
Review status: 9 of 10 files reviewed, all discussions resolved, all commit checks successful.
Comments from the review on Reviewable.io |
|
Review status: all files reviewed, 6 unresolved discussions, all commit checks successful.
components/script/dom/document.rs, line 655 [r1] (raw file): components/script/dom/document.rs, line 660 [r1] (raw file): components/script/dom/document.rs, line 698 [r1] (raw file): components/script/dom/document.rs, line 703 [r1] (raw file): components/script/dom/document.rs, line 712 [r1] (raw file): components/script/dom/document.rs, line 721 [r1] (raw file): Comments from the review on Reviewable.io |
|
|
|
|
|
@larsbergstrom re-r? |
|
Reviewed 1 of 11 files at r2. components/script/script_task.rs, line 1426 [r2] (raw file): Comments from the review on Reviewable.io |
|
Reviewed 8 of 11 files at r2. Comments from the review on Reviewable.io |
|
Reviewed 1 of 11 files at r2. Comments from the review on Reviewable.io |
|
@metajack GH still thinks it needs a rebase? Plus the one nit :-) |
|
@brunoabinader ping |
|
@metajack pong! I've rebased against master and fixed the nit Review status: 0 of 10 files reviewed at latest revision, all discussions resolved, all commit checks successful. Comments from the review on Reviewable.io |
|
@bors-servo: r+ |
|
|
|
Please do not merge yet, I found an issue in script_task related to misusage of |
|
@bors-servo: r- |
|
@bors-servo r=larsbergstrom |
|
|
Implement Msg::Status with serialized url upon mouseover Credits for Mike Blumenkrantz (@zmike), I just rebased against trunk and fixed the url serialization. Fixes #6178. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6181) <!-- Reviewable:end -->
|
|
Oops, that one didn't fired up on my OSX build. I've added a stub for glutin. |
|
@bors-servo r=larsbergstrom |
|
|
Implement Msg::Status with serialized url upon mouseover Credits for Mike Blumenkrantz (@zmike), I just rebased against trunk and fixed the url serialization. Fixes #6178. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6181) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
brunoabinader commentedMay 25, 2015
Credits for Mike Blumenkrantz (@zmike), I just rebased against trunk and
fixed the url serialization.
Fixes #6178.