fixes #5232, more console log levels sent to devtools

[j3parker]

fixes #5232

The correct styling shows up in the Firefox devtools (e.g. a caution symbol beside warning messages.)

I couldn't quickly find the corresponding Firefox code that handles log-levels so the values I'm sending are "guesses" (but they work seem to work.) I'll look today because I'm sending "log" for Debug-level, Error for failed asserts etc.

[highfive]

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @metajack (or someone else) soon.

[hoppipolla-critic-bot]

Critic review: https://critic.hoppipolla.co.uk/r/5107

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

[jdm]

I believe http://mxr.mozilla.org/mozilla-central/source/dom/base/Console.cpp#804 is the full set of levels.

[j3parker]

@jdm thanks! I'll switch to sending (console.table... interesting.)

Is there a more idiomatic way to serialize the LogLevel enum than the match I'm doing?

[jdm]

Not that I can think of.

[nox]

Looks ok to me, did you want to add something more or did something needs to be fixed, @j3parker? You can always implement the rest as a follow-up.

-S-awaiting-review +S-needs-squash

---

Review status: all files reviewed, all discussions resolved, all commit checks successful.
Reviewed files:

• components/devtools/lib.rs @ r3
• components/devtools_traits/lib.rs @ r1
• components/script/dom/console.rs @ r1

---

Comments from the review on Reviewable.io

[jdm]

Yep, a+ work. Thanks!

[j3parker]

I'm done as far as I know :) I squashed, thanks.

[jdm]

@bors-servo: r=nox

[bors-servo]

📌 Commit 78125db has been approved by nox

[bors-servo]

⌛ Testing commit 78125db with merge 534b720...

[bors-servo]

💔 Test failed - linux2

[j3parker]

Urg, I think I messed up while rebasing. Give me a second to see what happened.

[nox]

@j3parker

components/devtools/lib.rs:263:21: 263:37 error: no associated item named `Assert` found for type `devtools_traits::LogLevel` in the current scope
components/devtools/lib.rs:263                     LogLevel::Assert => "error",
                                                   ^~~~~~~~~~~~~~~~

[j3parker]

@nox yup, didn't mean to commit that :P build passes locally now.

[jdm]

@bors-servo: r=nox

[bors-servo]

📌 Commit a00d264 has been approved by nox

[bors-servo]

⌛ Testing commit a00d264 with merge ec79881...

[bors-servo]

💔 Test failed - mac2

[jdm]

@bors-servo: retry

• #6252

[bors-servo]

⚡ Previous build results for android, gonk, linux1, linux2, mac1 are reusable. Rebuilding only mac2...

[bors-servo]

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2