Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make throw_not_in_union() throw a TypeError (fixes #6194) #6206

Merged
merged 1 commit into from May 28, 2015
Merged

Make throw_not_in_union() throw a TypeError (fixes #6194) #6206

merged 1 commit into from May 28, 2015

Conversation

@nox
Copy link
Member

nox commented May 28, 2015

Review on Reviewable
@nox
Make throw_not_in_union() throw a TypeError (fixes #6194)
Loading status checks…
2c6d2d3
@nox nox force-pushed the nox:typeerror-for-unions branch from b44fdb4 to 2c6d2d3 May 28, 2015
@nox nox changed the title Make throw_not_in_union() throw a TypeError (fixes #6157) Make throw_not_in_union() throw a TypeError (fixes #6194) May 28, 2015
@Manishearth
Copy link
Member

Manishearth commented May 28, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented May 28, 2015

📌 Commit 2c6d2d3 has been approved by Manishearth
@nox nox mentioned this pull request May 28, 2015
Merged
@bors-servo
Copy link
Contributor

bors-servo commented May 28, 2015

⌛ Testing commit 2c6d2d3 with merge df74ed1...
bors-servo pushed a commit that referenced this pull request May 28, 2015
bors-servo
Auto merge of #6206 - nox:typeerror-for-unions, r=Manishearth
Loading status checks…
df74ed1 
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6206)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 28, 2015

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2
@bors-servo bors-servo mentioned this pull request May 28, 2015
Merged
@bors-servo bors-servo merged commit 2c6d2d3 into servo:master May 28, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@nox nox deleted the nox:typeerror-for-unions branch Aug 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-review
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@nox @Manishearth @bors-servo @highfive
You can’t perform that action at this time.