Merge generic funs to share them across all bindings (fixes #2684)

[nox]

[highfive]

Warning

• These commits modify unsafe code. Please review it carefully!

[hoppipolla-critic-bot]

Critic review: https://critic.hoppipolla.co.uk/r/5136

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

[nox]

I am pretty sure GetProtoObject() can be shared too.

[jdm]

I'd like to hold off on merging these changes until after #6150.

[nox]

Why? Don't you want to review again 175 files after I bitrot them? Agreed. :)

[metajack]

Assigning to @Ms2ger since @jdm will be out by the time #6150 lands.

[nox]

@Ms2ger Split as requested.

[bors-servo]

☔ The latest upstream changes (presumably #6272) made this pull request unmergeable. Please resolve the merge conflicts.

[Ms2ger]

Please rebase on master.

[nox]

@michaelwu r?

[Ms2ger]

Reviewed 2 of 2 files at r1, 3 of 4 files at r2.
Review status: 4 of 5 files reviewed at latest revision, 5 unresolved discussions, all commit checks successful.

---

^{components/script/dom/bindings/codegen/CodegenRust.py, line 2699 [r2] (raw file):}
We should be able to kill this now.

---

^{components/script/dom/bindings/codegen/CodegenRust.py, line 4586 [r2] (raw file):}
Remove those too?

---

^{components/script/dom/bindings/conversions.rs, line 575 [r2] (raw file):}
How does this not break proxy objects?

---

^{components/script/dom/bindings/conversions.rs, line 589 [r2] (raw file):}
Why mut obj?

---

^{components/script/dom/bindings/utils.rs, line 694 [r2] (raw file):}
There's a bunch of duplicated code in all those; could you share some more?

---

Comments from the review on Reviewable.io

[Ms2ger]

Reviewed 3 of 3 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

---

^{components/script/dom/bindings/utils.rs, line 678 [r3] (raw file):}
Perhaps get_this()

---

Comments from the review on Reviewable.io

[Ms2ger]

Reviewed 1 of 1 files at r4.
Review status: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

---

Comments from the review on Reviewable.io

[michaelwu]

Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

---

^{components/script/dom/bindings/utils.rs, line 691 [r3] (raw file):}
I usually wouldn't expect this to work. The rooters for GC things (Rooted<T>) usually can't be moved, so returning them is generally a bad idea unless that's the only thing you're returning and you use the special constructor that allows for this - Rooted::new_with_addr. If the assertion at https://github.com/servo/rust-mozjs/blob/master/src/rust.rs#L286 doesn't catch it though.. it's probably ok. The callers might be moving it to the right place if it works.

---

Comments from the review on Reviewable.io

[nox]

@Ms2ger Your turn again!

---

Review status: 4 of 5 files reviewed at latest revision, all discussions resolved, all commit checks successful.

---

Comments from the review on Reviewable.io

[Ms2ger]

-S-awaiting-review +S-needs-squash

---

Reviewed 1 of 1 files at r5.
Review status: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

---

Comments from the review on Reviewable.io

[Ms2ger]

@bors-servo r+

[bors-servo]

📌 Commit a909835 has been approved by Ms2ger

[bors-servo]

⌛ Testing commit a909835 with merge 6247a96...

[bors-servo]

☀️ Test successful - android, gonk, linux1, linux2, linux3, mac1, mac2, mac3