Remove `get_` prefix on getters

[frewsxcv]

Part of #6224

I certainly didn't remove all of them; I avoided unsafe areas and also components/script

[hoppipolla-critic-bot]

Critic review: https://critic.hoppipolla.co.uk/r/5138

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

[nox]

Review status: all files reviewed, 6 unresolved discussions, all commit checks successful.
Reviewed files:

• components/compositing/compositor.rs @ r1
• components/compositing/compositor_layer.rs @ r1
• components/compositing/compositor_task.rs @ r1
• components/devtools/actor.rs @ r1
• components/devtools/actors/network_event.rs @ r1
• components/devtools/actors/timeline.rs @ r1
• components/devtools/lib.rs @ r1
• components/gfx/font.rs @ r1
• components/gfx/font_context.rs @ r1
• components/gfx/paint_context.rs @ r1
• components/gfx/paint_task.rs @ r1
• components/gfx/platform/freetype/font.rs @ r1
• components/gfx/platform/macos/font.rs @ r1
• components/gfx/text/text_run.rs @ r1
• components/layout/construct.rs @ r1
• components/layout/fragment.rs @ r1
• components/layout/wrapper.rs @ r1
• components/msg/compositor_msg.rs @ r1
• components/net/fetch/cors_cache.rs @ r1
• components/script/clipboard_provider.rs @ r1
• components/script/textinput.rs @ r1

---

^{components/compositing/compositor.rs, line 498 [r1] (raw file):}
That's not exactly a plain old getter (it takes a PipelineId argument), should it really be renamed like this?

---

^{components/gfx/font.rs, line 44 [r1] (raw file):}
Maybe use a "compute_" prefix given the implementations are quite complex and do, well, computations?

---

^{components/gfx/paint_context.rs, line 681 [r1] (raw file):}
This method has many arguments, is that really a getter? Should we instead use another verb instead of just stripping the verb? There are many methods in Servo using "compute_" as a prefix, and this one looks like it could use it.

---

^{components/gfx/platform/freetype/font.rs, line 279 [r1] (raw file):}
face_rec_mut() maybe?

---

^{components/layout/construct.rs, line 1478 [r1] (raw file):}
construction_result_mut() maybe?

---

Comments from the review on Reviewable.io

[Manishearth]

Review status: all files reviewed, 4 unresolved discussions, all commit checks successful.

---

^{components/compositing/compositor.rs, line 498 [r1] (raw file):}
🚲 IMO it shouldn't be

---

^{components/gfx/paint_context.rs, line 681 [r1] (raw file):}
🚲 same, compute_ preferred

---

^{components/gfx/platform/freetype/font.rs, line 279 [r1] (raw file):}
🚲 👍

---

^{components/layout/construct.rs, line 1478 [r1] (raw file):}
🚲 👍

---

Comments from the review on Reviewable.io

[nox]

@bors-servo: r+

---

Review status: all files reviewed, all discussions resolved, all commit checks successful.
Reviewed files:

• components/compositing/compositor.rs @ r2
• components/compositing/compositor_layer.rs @ r2
• components/gfx/paint_context.rs @ r2
• components/gfx/platform/freetype/font.rs @ r2
• components/layout/construct.rs @ r2

---

Comments from the review on Reviewable.io

[bors-servo]

📌 Commit 7126d4d has been approved by nox

[nox]

@bors-servo: r-

Sorry @frewsxcv, please squash.

[frewsxcv]

It has been squashed

[nox]

@bors-servo: r+

-S-awaiting-review -S-needs-squash +S-awaiting-merge

---

Review status: all files reviewed, all discussions resolved, some commit checks pending.

---

Comments from the review on Reviewable.io

[bors-servo]

📌 Commit 435e551 has been approved by nox

[bors-servo]

⌛ Testing commit 435e551 with merge f6fe195...

[bors-servo]

☀️ Test successful - android, gonk, linux1, linux2, mac1, mac2