Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some unnecessary type annotations from the result of *Cast::from_ref. #6241

Closed
wants to merge 1 commit into from
Closed

Remove some unnecessary type annotations from the result of *Cast::from_ref. #6241

wants to merge 1 commit into from

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Jun 1, 2015

Review on Reviewable
@Ms2ger
Remove some unnecessary type annotations from the result of *Cast::fr…
Loading status checks…
8770ba1 
…om_ref.
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Jun 1, 2015

Critic review: https://critic.hoppipolla.co.uk/r/5146

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@jdm
Copy link
Member

jdm commented Jun 1, 2015

Let's leave this until after #6150.
@nox
Copy link
Member

nox commented Jun 1, 2015

With the changes to root() taking &self instead of self, there might be places where things are rooted only to be casted and then converted back to Temporary. As a related refactoring, these occurrences could use Cast::to_temporary.
@metajack
Copy link
Contributor

metajack commented Jun 2, 2015

Assigning to @glennw since @jdm will be out by the time #6150 lands.
@bors-servo
Copy link
Contributor

bors-servo commented Jun 6, 2015

☔ The latest upstream changes (presumably #6291) made this pull request unmergeable. Please resolve the merge conflicts.
@nox nox added the S-needs-rebase label Jun 6, 2015
@Ms2ger Ms2ger closed this Jun 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@glennw glennw

Labels
S-awaiting-review S-blocked-on-external S-needs-rebase
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
@Ms2ger @hoppipolla-critic-bot @jdm @nox @metajack @bors-servo @glennw @highfive
You can’t perform that action at this time.