Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upEnsure installed git version is above 1.8.1 [Bug #5637] #6246
Conversation
hoppipolla-critic-bot
commented
Jun 1, 2015
|
Critic review: https://critic.hoppipolla.co.uk/r/5150 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
| @@ -21,7 +21,7 @@ def download(desc, src, dst): | |||
| print("Downloading %s..." % desc) | |||
| dumb = (os.environ.get("TERM") == "dumb") or (not sys.stdout.isatty()) | |||
|
|
|||
| try: | |||
| try: | |||
This comment has been minimized.
This comment has been minimized.
|
I guess you are lucky it's not 1.8.2 and there are no 1.8.10. :) @bors-servo: r+ Review status:
Comments from the review on Reviewable.io |
all files reviewed, all discussions resolved, all commit checks successful.
|
|
|
|
Versions of git before 1.8.1 do not support git submodule --recursive sync This commit makes update_submodules() exit with an error message if the version is <1.8.1 #5637 -------------------- This was originally written by @ringmaster101. The commit was cherry-picked by @frewsxcv and modified to address the comments brought up in #5648 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6246) <!-- Reviewable:end -->
You're right, that was an oversight by me. I just learned about distutils.version so I can either change to use that now, open a new PR later, or just completely ignore it altogether |
|
@frewsxcv: Go ahead, that change is so old it can still wait a bit more I guess. @bors-servo: r- |
|
@bors-servo: r- force |
|
|
|
@nox look alright? |
|
Looks good. I was wary of it being an undocumented feature that might go away but it looks like Django uses it, so I guess it's safe to bet on it staying. @bors-servo: r+ Review status: 0 of 1 files reviewed, all discussions resolved, all commit checks successful. Comments from the review on Reviewable.io |
|
|
|
Cool, thanks @nox |
Versions of git before 1.8.1 do not support git submodule --recursive sync This commit makes update_submodules() exit with an error message if the version is <1.8.1 #5637 -------------------- This was originally written by @ringmaster101. The commit was cherry-picked by @frewsxcv and modified to address the comments brought up in #5648 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6246) <!-- Reviewable:end -->
frewsxcv commentedJun 1, 2015
Versions of git before 1.8.1 do not support git submodule --recursive sync
This commit makes update_submodules() exit with an error message if the version is <1.8.1
#5637
This was originally written by @ringmaster101. The commit was cherry-picked by @frewsxcv and modified to address the comments brought up in #5648