Only count outline width in overflow calculation if outline style is active.

[glennw]

This fixes layers being created with a 3x3 overflow that's not needed.

This exposes #6250, so update the affected reftest to use ahem font until it is fixed.

[hoppipolla-critic-bot]

Critic review: https://critic.hoppipolla.co.uk/r/5154

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

[glennw]

r? @pcwalton

[nox]

Review status: all files reviewed, 1 unresolved discussion, all commit checks successful.
Reviewed files:

• components/layout/fragment.rs @ r1
• tests/ref/inline_block_stacking_context_a.html @ r1
• tests/ref/inline_block_stacking_context_ref.html @ r1

---

^{components/layout/fragment.rs, line 2049 [r1] (raw file):}
This doesn't seem to be the right place to check for this, the spec says that the outline width's computed value must be 0 if the outline style is none.

My guess is that we should introduce a new type OutlineWidth which computes to 0 in its ToComputedValue implementation if outline-style is none in the context.

---

Comments from the review on Reviewable.io

[SimonSapin]

Review status: all files reviewed, 1 unresolved discussion, all commit checks successful.

---

^{components/layout/fragment.rs, line 2049 [r1] (raw file):}
Right, this should be done in a ToComputedValue impl like the one for border-*-width.

---

Comments from the review on Reviewable.io

[SimonSapin]

Review status: 4 of 5 files reviewed, 1 unresolved discussion, all commit checks successful.
Reviewed files:

• components/style/properties.mako.rs @ r2
• components/style/values.rs @ r2

---

Comments from the review on Reviewable.io

[nox]

Review status: all files reviewed, 2 unresolved discussions, all commit checks successful.
Reviewed files:

• components/layout/fragment.rs @ r2
• components/style/properties.mako.rs @ r2

---

^{components/style/properties.mako.rs, line 4525 [r2] (raw file):}
This should use properties::longhands::outline_width::parse (see for example how "background" is handled in this same file).

---

^{components/style/properties.mako.rs, line 4537 [r2] (raw file):}
As mentioned above, change the parse routine instead.

---

Comments from the review on Reviewable.io

[nox]

Feel free to squash everything while at it when you address my two last remarks.

On a more general note, if you know that the reviewer will use Reviewable, it's generally safe to just rebase and squash as you wish.

[frewsxcv]

Review status: all files reviewed, 3 unresolved discussions, all commit checks successful.

---

^{components/style/properties.mako.rs, line 5600 [r2] (raw file):}
This doesn't get assigned to anything; what's the point of the match?

---

Comments from the review on Reviewable.io

[frewsxcv]

Review status: all files reviewed, 2 unresolved discussions, all commit checks successful.

---

^{components/style/properties.mako.rs, line 5600 [r2] (raw file):}
Oh nevermind, the lack of indentation confused me. It would be nice if it was indented so that it is obvious there is something above it.

---

Comments from the review on Reviewable.io

[nox]

Review status: all files reviewed, 3 unresolved discussions, all commit checks successful.
Reviewed files:

• components/style/values.rs @ r2

---

^{components/style/properties.mako.rs, line 5603 [r2] (raw file):}
Indentation.

---

Comments from the review on Reviewable.io

[glennw]

Review status: 3 of 4 files reviewed, 3 unresolved discussions, all commit checks successful.

---

^{components/style/properties.mako.rs, line 4525 [r2] (raw file):}
Done.

---

^{components/style/properties.mako.rs, line 4537 [r2] (raw file):}
Done.

---

^{components/style/properties.mako.rs, line 5603 [r2] (raw file):}
Was copy pasted from the block below - updated to fix both blocks.

---

Comments from the review on Reviewable.io

[nox]

@bors-servo: r+

-S-awaiting-review +S-awaiting-merge

---

Review status: all files reviewed, all discussions resolved, all commit checks successful.
Reviewed files:

• components/style/properties.mako.rs @ r3

---

Comments from the review on Reviewable.io

[bors-servo]

📌 Commit 958adc0 has been approved by nox

[bors-servo]

⌛ Testing commit 958adc0 with merge 610de77...

[bors-servo]

☀️ Test successful - android, gonk, linux1, linux2, linux3, mac1, mac2