Fix #6242 testbinding add specialoperations

[ghost]

[highfive]

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @larsbergstrom (or someone else) soon.

[nox]

-S-awaiting-review +S-needs-code-changes

---

Review status: all files reviewed, 3 unresolved discussions, all commit checks successful.
Reviewed files:

• components/script/dom/mod.rs @ r2
• components/script/dom/testbindingproxy.rs @ r2
• components/script/dom/webidls/TestBindingProxy.webidl @ r1

---

^{components/script/dom/testbindingproxy.rs, line 7 [r2] (raw file):}
Nit: remove braces.

---

^{components/script/dom/testbindingproxy.rs, line 14 [r2] (raw file):}
Nit: the global field is useless.

---

^{components/script/dom/webidls/TestBindingProxy.webidl, line 6 [r2] (raw file):}
Nit: this is not true, please rephrase.

---

Comments from the review on Reviewable.io

[nox]

-S-awaiting-review +S-awaiting-answer

---

Review status: all files reviewed, 4 unresolved discussions, all commit checks successful.
Reviewed files:

• components/script/dom/testbindingproxy.rs @ r3
• components/script/dom/webidls/TestBindingProxy.webidl @ r3

---

^{components/script/dom/testbindingproxy.rs, line 12 [r3] (raw file):}
I just noticed that this is called reflector_ in all other structures and I have no idea why. Will r+ or tell you to change it once someone tells me if it's important or not. @jdm? @Manisheart?

---

Comments from the review on Reviewable.io

[nox]

-S-awaiting-answer +S-needs-code-changes

---

Review status: all files reviewed, 4 unresolved discussions, all commit checks successful.

---

^{components/script/dom/testbindingproxy.rs, line 12 [r3] (raw file):}
@Manishearth just told me it's to avoid clashing with the reflector() method, please rename to reflector_.

---

Comments from the review on Reviewable.io

[nox]

Squash everything and I'll r+ it. :)

-S-awaiting-review +S-needs-squash

---

Review status: all files reviewed, 4 unresolved discussions, all commit checks successful.
Reviewed files:

• components/script/dom/testbinding.rs @ r4
• components/script/dom/testbindingproxy.rs @ r4

---

Comments from the review on Reviewable.io

[ghost]

Done!

[nox]

@bors-servo: r+

-S-awaiting-review -S-needs-squash +S-awaiting-merge

---

Review status: all files reviewed, 4 unresolved discussions, all commit checks successful.

---

Comments from the review on Reviewable.io

[bors-servo]

📌 Commit 3c60917 has been approved by nox

[bors-servo]

⌛ Testing commit 3c60917 with merge b968cdf...

[bors-servo]

💔 Test failed - linux2

[nox]

/XMLHttpRequest/timeout-cors-async.htm
--------------------------------------
PASS expected FAIL XMLHttpRequest: timeout event and cross-origin request
/html/webappapis/scripting/processing-model-2/compile-error-cross-origin.html
-----------------------------------------------------------------------------
NOTRUN expected FAIL window.onerror - compile error in 
NOTRUN expected FAIL window.onerror - compile error in <script src=//www1...> (column)
TIMEOUT [Parent]
/_mozilla/mozilla/interfaces.html
---------------------------------
FAIL Interfaces exposed on the window

You need to patch the second list in /_mozilla/mozilla/interfaces.html and add TestBindingProxy in it.

[nox]

The two other failing tests are probably intermittent.

[nox]

@bors-servo: r+

-S-awaiting-review +S-awaiting-merge

---

Review status: all files reviewed, 4 unresolved discussions, all commit checks successful.
Reviewed files:

• tests/wpt/mozilla/tests/mozilla/interfaces.html @ r6

---

Comments from the review on Reviewable.io

[bors-servo]

📌 Commit 4ada1e9 has been approved by nox

[bors-servo]

⌛ Testing commit 4ada1e9 with merge 44a4b78...

[bors-servo]

☀️ Test successful - android, gonk, linux1, linux2, linux3, mac1, mac2