Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert inline(always) to inline in CodegenRust and jstraceable. #6297

Merged
merged 1 commit into from Jun 6, 2015
Merged

Convert inline(always) to inline in CodegenRust and jstraceable. #6297

merged 1 commit into from Jun 6, 2015

Conversation

brson
Copy link
Contributor

@brson brson commented Jun 5, 2015

This results in a 14% compile time improvement.

See https://gist.github.com/brson/b48dd03b06c406be68e6

I'm not suggesting you merge this as-is, but you might consider whether removing some of these is worth pursuing.

Review on Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jun 5, 2015
@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/5200

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@Manishearth
Copy link
Member

r+ on the plugins change. I had added that to optimize away most of the empty trace impls, but llvm can probably do that on its own.

r? @jdm @Ms2ger on the codegen change. There may be reasons for force-inlining those.

@jdm
Copy link
Member

jdm commented Jun 6, 2015

I don't believe anybody ever measured. I'm willing to make the change to reduce compile times and change it back in the future if it's identified as a performance problem.

@jdm
Copy link
Member

jdm commented Jun 6, 2015

@bors-servo: r+

@bors-servo
Copy link
Contributor

📌 Commit 172fbca has been approved by jdm

@jdm jdm added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jun 6, 2015
@bors-servo
Copy link
Contributor

⌛ Testing commit 172fbca with merge 7866533...

bors-servo pushed a commit that referenced this pull request Jun 6, 2015
Auto merge of #6297 - brson:inline, r=jdm
7866533 
This results in a 14% compile time improvement.

See https://gist.github.com/brson/b48dd03b06c406be68e6

I'm not suggesting you merge this as-is, but you might consider whether removing some of these is worth pursuing.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6297)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux1, linux2, linux3, mac1, mac2

@bors-servo bors-servo merged commit 172fbca into servo:master Jun 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@brson @hoppipolla-critic-bot @Manishearth @jdm @bors-servo @highfive