Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unit testing of util::mem. #6346

Merged
merged 1 commit into from Jun 12, 2015

Conversation

@nnethercote
Copy link
Contributor

nnethercote commented Jun 11, 2015

@highfive
Copy link

highfive commented Jun 11, 2015

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Jun 11, 2015

Critic review: https://critic.hoppipolla.co.uk/r/5253

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@Manishearth
Copy link
Member

Manishearth commented Jun 12, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2015

📌 Commit ab59a20 has been approved by Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2015

Testing commit ab59a20 with merge 225d758...

bors-servo pushed a commit that referenced this pull request Jun 12, 2015
…arth

r? @Manishearth

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6346)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2015

💔 Test failed - mac1

@Manishearth
Copy link
Member

Manishearth commented Jun 12, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2015

Previous build results for android, gonk, linux1, linux2, linux3, mac2 are reusable. Rebuilding only mac1...

@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2015

💔 Test failed - mac1

@Manishearth
Copy link
Member

Manishearth commented Jun 12, 2015

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2015

Previous build results for android, gonk, linux1, linux2, linux3, mac2 are reusable. Rebuilding only mac1...

@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2015

💔 Test failed - mac1

@Manishearth
Copy link
Member

Manishearth commented Jun 12, 2015

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2015

Testing commit ab59a20 with merge b9d53a2...

bors-servo pushed a commit that referenced this pull request Jun 12, 2015
…arth

r? @Manishearth

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6346)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 12, 2015

☀️ Test successful - android, gonk, linux1, linux2, linux3, mac1, mac2

@bors-servo bors-servo merged commit ab59a20 into servo:master Jun 12, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@nnethercote nnethercote deleted the nnethercote:improve-mem-unit-testing branch Jun 12, 2015
@nnethercote
Copy link
Contributor Author

nnethercote commented Jun 12, 2015

Thank you for babysitting the change through the intermittent failures, @Manishearth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.