Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update glutin window port for changes incurred in rebase #6409

Closed
wants to merge 1 commit into from
Closed

update glutin window port for changes incurred in rebase #6409

wants to merge 1 commit into from

Conversation

@zmike
Copy link
Contributor

zmike commented Jun 18, 2015

MouseScrollDelta is now an enum of pair values

r? @glennw

depends on servo/glutin #36 and a cargo glutin update

Review on Reviewable
Mike Blumenkrantz
update glutin window port for changes incurred in rebase
Loading status checks…
9380800 
MouseScrollDelta is now an enum of pair values
@highfive
Copy link

highfive commented Jun 18, 2015

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@zmike
Copy link
Contributor Author

zmike commented Jun 18, 2015

@larsbergstrom also
@robertknight
Copy link

robertknight commented Jun 18, 2015

@zmike - There is a separate PR for the MouseScrollDelta changes - #6373 . When scroll values are in lines they need to be scaled by a suitable value.
@bors-servo
Copy link
Contributor

bors-servo commented Jun 22, 2015

☔ The latest upstream changes (presumably #6445) made this pull request unmergeable. Please resolve the merge conflicts.
@zmike
Copy link
Contributor Author

zmike commented Jun 26, 2015

Hmm I updated this again but it's not getting pulled into this PR. I'll create a new one if nothing happens at the time when this is getting reviewed.
@metajack
Copy link
Contributor

metajack commented Jul 29, 2015

@glennw ping. This is quite old now.
@paulrouget
Copy link
Contributor

paulrouget commented Aug 8, 2015

#7096
@glennw
Copy link
Member

glennw commented Sep 1, 2015

This was superseded by #7096.
@glennw glennw closed this Sep 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@glennw glennw

Labels
S-awaiting-review S-needs-rebase
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@zmike @highfive @robertknight @bors-servo @metajack @paulrouget @glennw
You can’t perform that action at this time.