Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create pattern from HTMLCanvasElement or CanvasRenderingContext2D. #6410

Merged
merged 1 commit into from
Jun 24, 2015
Merged

Create pattern from HTMLCanvasElement or CanvasRenderingContext2D. #6410

merged 1 commit into from
Jun 24, 2015

Conversation

hyowon
Copy link
Contributor

@hyowon hyowon commented Jun 18, 2015

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jun 18, 2015
@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/5312

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@pcwalton
Copy link
Contributor

@bors-servo: r+

Thanks!

@bors-servo
Copy link
Contributor

📌 Commit e2ef576 has been approved by pcwalton

@bors-servo
Copy link
Contributor

⌛ Testing commit e2ef576 with merge c96cda9...

bors-servo pushed a commit that referenced this pull request Jun 18, 2015
Auto merge of #6410 - hyowon:create_pattern, r=pcwalton
c96cda9 
Create pattern from HTMLCanvasElement or CanvasRenderingContext2D.

r? @nox @pcwalton 
cc @yichoi

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6410)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac2

@hyowon
Copy link
Contributor Author

hyowon commented Jun 18, 2015

@pcwalton Failed viewport_percentage_vw_vh.html which seems unrelated to this patch. Please retry?

@bors-servo
Copy link
Contributor

☔ The latest upstream changes (presumably #6150) made this pull request unmergeable. Please resolve the merge conflicts.

@nox nox added the S-needs-rebase There are merge conflict errors. label Jun 21, 2015
@jdm
Copy link
Member

jdm commented Jun 21, 2015

Yes, the failed test is tracked in #6252.

@jdm jdm removed the S-awaiting-review There is new code that needs to be reviewed. label Jun 21, 2015
@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jun 22, 2015
@hyowon
Copy link
Contributor Author

hyowon commented Jun 22, 2015

Rebase has been done.

@Ms2ger
Copy link
Contributor

Ms2ger commented Jun 23, 2015

Could you change the &&HTMLCanvasElement to &HTMLCanvasElement?

@Ms2ger Ms2ger added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. S-needs-rebase There are merge conflict errors. labels Jun 23, 2015
@highfive highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Jun 24, 2015
@hyowon
Copy link
Contributor Author

hyowon commented Jun 24, 2015

@Ms2ger Sure. Done.

@Ms2ger
Copy link
Contributor

Ms2ger commented Jun 24, 2015

@bors-servo r=pcwalton

@bors-servo
Copy link
Contributor

📌 Commit 0e8491f has been approved by pcwalton

@bors-servo
Copy link
Contributor

⌛ Testing commit 0e8491f with merge 95d643c...

bors-servo pushed a commit that referenced this pull request Jun 24, 2015
Auto merge of #6410 - hyowon:create_pattern, r=pcwalton
95d643c 
Create pattern from HTMLCanvasElement or CanvasRenderingContext2D.

r? @nox @pcwalton 
cc @yichoi

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6410)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux1, linux2, linux3, mac1, mac2, mac3

@bors-servo bors-servo merged commit 0e8491f into servo:master Jun 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-review There is new code that needs to be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@hyowon @hoppipolla-critic-bot @pcwalton @bors-servo @jdm @Ms2ger @nox @highfive