Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ARM linker #6421

Merged
merged 1 commit into from Jun 20, 2015
Merged

Fix ARM linker #6421

merged 1 commit into from Jun 20, 2015

Conversation

@mmatyas
Copy link
Contributor

mmatyas commented Jun 18, 2015

By default, cc is used for the final linking of servo, which points to the host's compiler. This patch ensures that the correct linker is used for cross-compiling to ARM.

Part of #6327

Review on Reviewable
@mmatyas
Fix ARM linker
Loading status checks…
2efc18a
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Jun 18, 2015

Critic review: https://critic.hoppipolla.co.uk/r/5325

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@mmatyas mmatyas mentioned this pull request Jun 18, 2015
Closed
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Jun 20, 2015

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 20, 2015

📌 Commit 2efc18a has been approved by larsbergstrom
@bors-servo
Copy link
Contributor

bors-servo commented Jun 20, 2015

⌛ Testing commit 2efc18a with merge fa45688...
bors-servo pushed a commit that referenced this pull request Jun 20, 2015
bors-servo
Auto merge of #6421 - mmatyas:arm_build2, r=larsbergstrom
Loading status checks…
fa45688 
Fix ARM linker

By default, `cc` is used for the final linking of servo, which points to the host's compiler. This patch ensures that the correct linker is used for cross-compiling to ARM.

Part of #6327

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6421)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 20, 2015

☀️ Test successful - android, gonk, linux1, linux2, linux3, mac1, mac2, mac3
@bors-servo bors-servo merged commit 2efc18a into servo:master Jun 20, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@larsbergstrom larsbergstrom

Labels
S-awaiting-review
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@mmatyas @hoppipolla-critic-bot @larsbergstrom @bors-servo @highfive
You can’t perform that action at this time.