Various CEF refactoring.

[Ms2ger]

[hoppipolla-critic-bot]

Critic review: https://critic.hoppipolla.co.uk/r/5334

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

[zmike]

Review status: 0 of 6 files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.

---

^{ports/cef/string_map.rs, line 65 [r11] (raw file):}
Maybe slightly outside the scope of this patchset, but I think it should just return the value of this function here instead of 1.

---

^{ports/cef/string_map.rs, line 84 [r11] (raw file):}
Same as above.

---

Comments from the review on Reviewable.io

[zmike]

Reviewed 1 of 1 files at r1, 1 of 1 files at r5, 1 of 1 files at r7, 1 of 2 files at r8, 1 of 1 files at r10, 1 of 1 files at r11.
Review status: all files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.

---

Comments from the review on Reviewable.io

[zmike]

Okay, it seems we've had some regressions in CEF string APIs (or maybe rust?) since I last ran full unit tests.

Now we have errors which were not present earlier, seen here: https://gist.github.com/zmike/9115f37d88380e5e9fc9

Given that I've verified the errors were not introduced in this patchset, I'll still give r+ here, but I guess now I should also create another ticket...

[zmike]

Reviewed 1 of 1 files at r12.
Review status: all files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.

---

Comments from the review on Reviewable.io

[Ms2ger]

@bors-servo r=zmike

[bors-servo]

📌 Commit da53a9c has been approved by zmike

[bors-servo]

⌛ Testing commit da53a9c with merge 6e04c12...

[bors-servo]

☀️ Test successful - android, gonk, linux1, linux2, linux3, mac1, mac2, mac3