Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust-mozjs. #6440

Merged
merged 1 commit into from Jun 22, 2015
Merged

Update rust-mozjs. #6440

merged 1 commit into from Jun 22, 2015

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Jun 21, 2015

Review on Reviewable
@Ms2ger
Update rust-mozjs.
Loading status checks…
2afbf7f
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Jun 21, 2015

Critic review: https://critic.hoppipolla.co.uk/r/5337

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Jun 21, 2015

servo/rust-mozjs#159
@metajack
Copy link
Contributor

metajack commented Jun 22, 2015

@bors-servo r+

-S-awaiting-review +S-awaiting-merge

Reviewed 3 of 3 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from the review on Reviewable.io
@bors-servo
Copy link
Contributor

bors-servo commented Jun 22, 2015

📌 Commit 2afbf7f has been approved by metajack
@bors-servo
Copy link
Contributor

bors-servo commented Jun 22, 2015

⌛ Testing commit 2afbf7f with merge d85afb7...
bors-servo pushed a commit that referenced this pull request Jun 22, 2015
bors-servo
Auto merge of #6440 - Ms2ger:finalizeInBackground, r=metajack
Loading status checks…
d85afb7 
Update rust-mozjs.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6440)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 22, 2015

💔 Test failed - mac2
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Jun 22, 2015

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jun 22, 2015

⚡ Previous build results for android, gonk, linux1, linux2, linux3, mac1, mac3 are reusable. Rebuilding only mac2...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 22, 2015

💔 Test failed - mac2
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Jun 22, 2015

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jun 22, 2015

⚡ Previous build results for android, gonk, linux1, linux2, linux3, mac1, mac3 are reusable. Rebuilding only mac2...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 22, 2015

☀️ Test successful - android, gonk, linux1, linux2, linux3, mac1, mac2, mac3
@bors-servo bors-servo merged commit 2afbf7f into servo:master Jun 22, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the Ms2ger:finalizeInBackground branch Jun 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @hoppipolla-critic-bot @metajack @bors-servo @highfive
You can’t perform that action at this time.