Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate rust-selectors #6468
Update rust-selectors #6468
Conversation
highfive
commented
Jun 26, 2015
hoppipolla-critic-bot
commented
Jun 26, 2015
|
Critic review: https://critic.hoppipolla.co.uk/r/5381 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
Reviewed 12 of 12 files at r1. components/layout/css/matching.rs, line 230 [r1] (raw file): components/layout/css/matching.rs, line 508 [r1] (raw file): components/layout/css/matching.rs, line 510 [r1] (raw file): components/layout/wrapper.rs, line 71 [r1] (raw file): components/layout/wrapper.rs, line 251 [r1] (raw file): components/layout/wrapper.rs, line 255 [r1] (raw file): Comments from the review on Reviewable.io |
|
Review status: all files reviewed at latest revision, 6 unresolved discussions, all commit checks successful. components/layout/css/matching.rs, line 230 [r1] (raw file): components/layout/css/matching.rs, line 508 [r1] (raw file): components/layout/css/matching.rs, line 510 [r1] (raw file): components/layout/wrapper.rs, line 71 [r1] (raw file): components/layout/wrapper.rs, line 251 [r1] (raw file): components/layout/wrapper.rs, line 255 [r1] (raw file): Comments from the review on Reviewable.io |
|
Reviewed 2 of 2 files at r2. Comments from the review on Reviewable.io |
|
-S-awaiting-review +S-awaiting-merge @bors-servo r+ Review status: Comments from the review on Reviewable.io |
|
|
Update rust-selectors r? @Ms2ger servo/rust-selectors#33 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6468) <!-- Reviewable:end -->
SimonSapin commentedJun 26, 2015
r? @Ms2ger
servo/rust-selectors#33