Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust-selectors #6468

Merged
merged 1 commit into from Jun 26, 2015
Merged

Update rust-selectors #6468

merged 1 commit into from Jun 26, 2015

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Jun 26, 2015

@highfive
Copy link

highfive commented Jun 26, 2015

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Jun 26, 2015

Critic review: https://critic.hoppipolla.co.uk/r/5381

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@Ms2ger
Copy link
Contributor

Ms2ger commented Jun 26, 2015

Reviewed 12 of 12 files at r1.
Review status: all files reviewed at latest revision, 6 unresolved discussions, all commit checks successful.


components/layout/css/matching.rs, line 230 [r1] (raw file):
let element = match...


components/layout/css/matching.rs, line 508 [r1] (raw file):
Followup to implement this on Element instead?


components/layout/css/matching.rs, line 510 [r1] (raw file):
match parent_node.as_element()?


components/layout/wrapper.rs, line 71 [r1] (raw file):
Unused


components/layout/wrapper.rs, line 251 [r1] (raw file):
Not anymore


components/layout/wrapper.rs, line 255 [r1] (raw file):
.map()?


Comments from the review on Reviewable.io

@SimonSapin SimonSapin force-pushed the update-selectors branch from ad0a84a to 9e1a674 Jun 26, 2015
@SimonSapin
Copy link
Member Author

SimonSapin commented Jun 26, 2015

Review status: all files reviewed at latest revision, 6 unresolved discussions, all commit checks successful.


components/layout/css/matching.rs, line 230 [r1] (raw file):
Done.


components/layout/css/matching.rs, line 508 [r1] (raw file):
#6476


components/layout/css/matching.rs, line 510 [r1] (raw file):
parent_node as that point is Option<LayoutNode>, we can’t call as_element on it yet.


components/layout/wrapper.rs, line 71 [r1] (raw file):
It is used to call methods like prev_sibling.


components/layout/wrapper.rs, line 251 [r1] (raw file):
Fixed.


components/layout/wrapper.rs, line 255 [r1] (raw file):
Done.


Comments from the review on Reviewable.io

@Ms2ger
Copy link
Contributor

Ms2ger commented Jun 26, 2015

Reviewed 2 of 2 files at r2.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from the review on Reviewable.io

@Ms2ger
Copy link
Contributor

Ms2ger commented Jun 26, 2015

-S-awaiting-review +S-awaiting-merge

@bors-servo r+


Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from the review on Reviewable.io

@bors-servo
Copy link
Contributor

bors-servo commented Jun 26, 2015

📌 Commit 9e1a674 has been approved by Ms2ger

@bors-servo
Copy link
Contributor

bors-servo commented Jun 26, 2015

Testing commit 9e1a674 with merge c331db1...

bors-servo pushed a commit that referenced this pull request Jun 26, 2015
Update rust-selectors

r? @Ms2ger

servo/rust-selectors#33

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6468)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 26, 2015

☀️ Test successful - android, gonk, linux1, linux2, linux3, mac1, mac2, mac3

@bors-servo bors-servo merged commit 9e1a674 into master Jun 26, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the update-selectors branch Jun 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.