Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HSTS (preload-only) #6490

Merged
merged 24 commits into from Jul 22, 2015
Merged

Implement HSTS (preload-only) #6490

merged 24 commits into from Jul 22, 2015

Commits on Jul 21, 2015

  1. Preload an HSTS domain list from chromium

    This resolves the first part of #6105. The remaining part is
    to update the list based on the STS headers from the server.
    samfoo committed Jul 21, 2015
  2. Implement mutable HSTS list

    This prepares the resource task to update the HSTS list when it sees STS
    headers. This will allow full HSTS support for #6105 when the
    resource task implements the header checking
    samfoo committed Jul 21, 2015
  3. Do not allow IP address in HSTS list

    As per [rfc6797](https://tools.ietf.org/html/rfc6797#section-8.1.1), do
    not allow IPv4 or IPv6 addresses as host entries into the HSTS list.
    
    #6105
    samfoo committed Jul 21, 2015
  4. Add max-age to HSTS entries

    Refactors API for pushing new entries on, and adds a max age. This does
    not add a check for the max-age, or remove old entries from the list.
    Instead this just adds the data-field.
    
    #6105
    samfoo committed Jul 21, 2015
  5. Rename/refactor

    samfoo committed Jul 21, 2015
  6. Abstract out ResourceManager messaging from impl

    De-coupling makes testing a bit easier.
    samfoo committed Jul 21, 2015
  7. Resolve tidy issues

    samfoo committed Jul 21, 2015
  8. Commit HSTS preload list to source control

    * No longer download the HSTS list as a bootstrap step
    * Check the current revision of the HSTS list into source
    samfoo committed Jul 21, 2015
  9. Resolves code review comments

    * Lots of rust-isms
    * Mutable iterator for modifying entries (much better)
    samfoo committed Jul 21, 2015
  10. Resolves remaining code review issues

    * Don't pass a boolean to the HSTSEntry constructor, use an enum instead
    * Don't clone when securing load data
    * Comment about the Url bug
    * Change remaining assert!(... == ...) to assert_eq!(..., ...)
    samfoo committed Jul 21, 2015
  11. Moves the HSTS replacement code to http_loader

    This respects STS for redirects as well.
    samfoo committed Jul 21, 2015
  12. Responds to more code review feedback

    * Use regex from resource task
    * Don't have an option of an HSTS list, default to empty
    samfoo committed Jul 21, 2015
  13. Only secure URL's that aren't already to HTTPS.

    Cuts down on logger spam, and unnecessary Url::clone's
    samfoo committed Jul 21, 2015
You can’t perform that action at this time.