Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make devtools usable once more. #6540

Merged
merged 2 commits into from Jul 7, 2015
Merged

Make devtools usable once more. #6540

merged 2 commits into from Jul 7, 2015

Conversation

@jdm
Copy link
Member

jdm commented Jul 3, 2015

This fixes the panic by rebasing #6189, and also makes cached messages appear once more.

Review on Reviewable

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Jul 3, 2015

Critic review: https://critic.hoppipolla.co.uk/r/5455

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@glennw
Copy link
Member

glennw commented Jul 7, 2015

Reviewed 1 of 1 files at r1, 3 of 3 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.


components/devtools/lib.rs, line 255 [r2] (raw file):
Should we print a debug warning here or is it expected?


components/devtools/lib.rs, line 306 [r2] (raw file):
Should we print a debug warning here or is it expected?


Comments from the review on Reviewable.io

@jdm
Copy link
Member Author

jdm commented Jul 7, 2015

Review status: all files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.


components/devtools/lib.rs, line 255 [r2] (raw file):
Expected.


components/devtools/lib.rs, line 306 [r2] (raw file):
Expected.


Comments from the review on Reviewable.io

@glennw
Copy link
Member

glennw commented Jul 7, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Jul 7, 2015

📌 Commit 81c0d32 has been approved by glennw

@bors-servo
Copy link
Contributor

bors-servo commented Jul 7, 2015

Testing commit 81c0d32 with merge c04b7bb...

bors-servo pushed a commit that referenced this pull request Jul 7, 2015
Make devtools usable once more.

This fixes the panic by rebasing #6189, and also makes cached messages appear once more.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6540)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 7, 2015

☀️ Test successful - android, gonk, linux1, linux2, linux3, mac1, mac2, mac3

@bors-servo bors-servo merged commit 81c0d32 into servo:master Jul 7, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@jdm jdm deleted the jdm:devtoolsfix branch Aug 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.