Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake devtools usable once more. #6540
Conversation
hoppipolla-critic-bot
commented
Jul 3, 2015
|
Critic review: https://critic.hoppipolla.co.uk/r/5455 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
Reviewed 1 of 1 files at r1, 3 of 3 files at r2. components/devtools/lib.rs, line 255 [r2] (raw file): components/devtools/lib.rs, line 306 [r2] (raw file): Comments from the review on Reviewable.io |
|
Review status: all files reviewed at latest revision, 2 unresolved discussions, all commit checks successful. components/devtools/lib.rs, line 255 [r2] (raw file): components/devtools/lib.rs, line 306 [r2] (raw file): Comments from the review on Reviewable.io |
|
@bors-servo r+ |
|
|
Make devtools usable once more. This fixes the panic by rebasing #6189, and also makes cached messages appear once more. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6540) <!-- Reviewable:end -->
jdm commentedJul 3, 2015
This fixes the panic by rebasing #6189, and also makes cached messages appear once more.