Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate most dependencies. #6562
Closed
+250
−229
Conversation
hoppipolla-critic-bot
commented
Jul 6, 2015
|
Critic review: https://critic.hoppipolla.co.uk/r/5473 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
@bors-servo: r+ |
|
|
bors-servo
pushed a commit
that referenced
this pull request
Jul 6, 2015
Update most dependencies. This excludes * layers, as its latest commits have an API change we still need to adapt to; * hyper, as it gained a dependency on the solicit crate, which triggers an ICE in the current rustc (<rust-lang/rust#26805>); * websocket, as it depends on a hyper API change; * tenacious, as it has not yet been updated to the current rustc (<Manishearth/rust-tenacious#6>). Unfortunately, this adds a third copy of bitflags to our dependencies; I've created pull requests to the guilty dependencies: <sfackler/rust-openssl#236> and <servo/cocoa-rs#94>. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6562) <!-- Reviewable:end -->
|
|
|
This excludes * layers, as its latest commits have an API change we still need to adapt to; * hyper, as it gained a dependency on the solicit crate, which triggers an ICE in the current rustc (<rust-lang/rust#26805>); * websocket, as it depends on a hyper API change; * tenacious, as it has not yet been updated to the current rustc (<Manishearth/rust-tenacious#6>). Unfortunately, this adds a third copy of bitflags to our dependencies; I've created pull requests to the guilty dependencies: <sfackler/rust-openssl#236> and <servo/cocoa-rs#94>.
|
@bors-servo r=jdm |
|
|
bors-servo
pushed a commit
that referenced
this pull request
Jul 6, 2015
Update most dependencies. This excludes * layers, as its latest commits have an API change we still need to adapt to; * hyper, as it gained a dependency on the solicit crate, which triggers an ICE in the current rustc (<rust-lang/rust#26805>); * websocket, as it depends on a hyper API change; * tenacious, as it has not yet been updated to the current rustc (<Manishearth/rust-tenacious#6>). Unfortunately, this adds a third copy of bitflags to our dependencies; I've created pull requests to the guilty dependencies: <sfackler/rust-openssl#236> and <servo/cocoa-rs#94>. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6562) <!-- Reviewable:end -->
|
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Ms2ger commentedJul 6, 2015
This excludes
in the current rustc (rust-lang/rust#26805);
(Manishearth/rust-tenacious#6).
Unfortunately, this adds a third copy of bitflags to our dependencies; I've
created pull requests to the guilty dependencies:
sfackler/rust-openssl#236 and
servo/cocoa-rs#94.