Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the scope of the allowed unsafe code in context.rs. #6576

Merged
merged 1 commit into from Jul 8, 2015
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Reduce the scope of the allowed unsafe code in context.rs.

Since I made unsafe code opt-in in layout, the unsafe code in this module has
been reduced to a single unsafe impl, so there is no reason to allow it in
the entire module.
  • Loading branch information
Ms2ger committed Jul 8, 2015
commit 270f0aafed48aa5abd3b9ab56f55af28c582a781
@@ -4,7 +4,7 @@

//! Data needed by the layout task.

#![allow(unsafe_code)]
#![deny(unsafe_code)]

use css::matching::{ApplicableDeclarationsCache, StyleSharingCandidateCache};

@@ -138,6 +138,7 @@ pub struct SharedLayoutContext {
// XXX UNSOUND!!! for stylist
// XXX UNSOUND!!! for new_animations_sender
// XXX UNSOUND!!! for canvas_layers_sender
#[allow(unsafe_code)]
unsafe impl Sync for SharedLayoutContext {}

pub struct LayoutContext<'a> {
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.