Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gfx: Make display lists serializable using `serde`. #6583

Merged
merged 1 commit into from Jul 16, 2015
Merged

gfx: Make display lists serializable using `serde`. #6583

merged 1 commit into from Jul 16, 2015

Conversation

@pcwalton
Copy link
Contributor

pcwalton commented Jul 8, 2015

This commit introduces the serde dependency, which we will use to
serialize messages going between processes in multiprocess Servo.

This also adds a new debugging flag, -Z print-display-list-json,
allowing the output of display list serialization to be visualized.
This will be useful for our experiments with alternate rasterizers.

r? @metajack

Review on Reviewable
@metajack
Copy link
Contributor

metajack commented Jul 8, 2015

-S-awaiting-review +S-needs-code-changes

Reviewed 34 of 34 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

components/gfx/platform/macos/font_template.rs, line 52 [r1] (raw file):
This needs some documentation.

Comments from the review on Reviewable.io
@pcwalton pcwalton force-pushed the pcwalton:serializable-display-list branch from 6ba6dde to cd86ad0 Jul 9, 2015
@pcwalton
Copy link
Contributor Author

pcwalton commented Jul 9, 2015

Switched to Deref on LinkedList.

r? @metajack
@metajack
Copy link
Contributor

metajack commented Jul 9, 2015

Missing Cargo.lock updates for the other ports.

-S-awaiting-review +S-needs-code-changes

Reviewed 5 of 5 files at r2.
Review status: all files reviewed at latest revision, 3 unresolved discussions, all commit checks successful.

components/gfx/font_context.rs, line 44 [r2] (raw file):
CachedCTFont should probably get deref treatment instead of .0 too.

components/gfx/platform/macos/font.rs, line 67 [r2] (raw file):
Same here.

Comments from the review on Reviewable.io
@pcwalton pcwalton force-pushed the pcwalton:serializable-display-list branch from cd86ad0 to 3cfcff9 Jul 11, 2015
@pcwalton
Copy link
Contributor Author

pcwalton commented Jul 11, 2015

@metajack Updated per your comments. r?
@bors-servo
Copy link
Contributor

bors-servo commented Jul 12, 2015

☔ The latest upstream changes (presumably #6606) made this pull request unmergeable. Please resolve the merge conflicts.
@metajack
Copy link
Contributor

metajack commented Jul 13, 2015

-S-awaiting-review +S-needs-code-changes +S-needs-rebase

r=me once you add the comment and rebase.

Reviewed 6 of 6 files at r3.
Review status: all files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

components/gfx/platform/macos/font_template.rs, line 53 [r3] (raw file):
This still needs a code comment. Why does this exist? When is it None vs. Some(CTFont)?

You already explained this to me in the discussion, but that needs to be recorded in the source.

Comments from the review on Reviewable.io
@pcwalton pcwalton force-pushed the pcwalton:serializable-display-list branch from 3cfcff9 to 54328ae Jul 13, 2015
@pcwalton
Copy link
Contributor Author

pcwalton commented Jul 13, 2015

Done. However, this is now blocked on servo/string-cache#92 due to some changes that landed while this was being reviewed.
@pcwalton
Copy link
Contributor Author

pcwalton commented Jul 14, 2015

Unfortunately, because string-cache has taken changes that require a rustup, this is now blocked on either the rustup or servo/string-cache#93.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 14, 2015

☔ The latest upstream changes (presumably #6596) made this pull request unmergeable. Please resolve the merge conflicts.
@pcwalton pcwalton force-pushed the pcwalton:serializable-display-list branch from 54328ae to b89cd04 Jul 15, 2015
@bors-servo
Copy link
Contributor

bors-servo commented Jul 15, 2015

☔ The latest upstream changes (presumably #6591) made this pull request unmergeable. Please resolve the merge conflicts.
@pcwalton
gfx: Make display lists serializable using `serde`.
Loading status checks…
6eacb0c 
This commit introduces the `serde` dependency, which we will use to
serialize messages going between processes in multiprocess Servo.

This also adds a new debugging flag, `-Z print-display-list-json`,
allowing the output of display list serialization to be visualized.
This will be useful for our experiments with alternate rasterizers.
@pcwalton pcwalton force-pushed the pcwalton:serializable-display-list branch from b89cd04 to 6eacb0c Jul 16, 2015
@pcwalton
Copy link
Contributor Author

pcwalton commented Jul 16, 2015

@bors-servo: r=metajack
@bors-servo
Copy link
Contributor

bors-servo commented Jul 16, 2015

📌 Commit 6eacb0c has been approved by metajack
@bors-servo
Copy link
Contributor

bors-servo commented Jul 16, 2015

⌛ Testing commit 6eacb0c with merge ef97152...
bors-servo pushed a commit that referenced this pull request Jul 16, 2015
bors-servo
Auto merge of #6583 - pcwalton:serializable-display-list, r=metajack
Loading status checks…
ef97152 
gfx: Make display lists serializable using `serde`.

This commit introduces the `serde` dependency, which we will use to
serialize messages going between processes in multiprocess Servo.

This also adds a new debugging flag, `-Z print-display-list-json`,
allowing the output of display list serialization to be visualized.
This will be useful for our experiments with alternate rasterizers.

r? @metajack

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6583)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 16, 2015

💔 Test failed - mac1
@pcwalton
Copy link
Contributor Author

pcwalton commented Jul 16, 2015

@bors-servo: retry

WPT test timeouts don't seem like they could be possibly related to a patch that adds a bunch of dead code.
@pcwalton
Copy link
Contributor Author

pcwalton commented Jul 16, 2015

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 16, 2015

⚡ Previous build results for android, gonk, linux1, linux2, linux3, mac2, mac3 are reusable. Rebuilding only mac1...
@jdm jdm mentioned this pull request Jul 16, 2015
Closed
@bors-servo
Copy link
Contributor

bors-servo commented Jul 16, 2015

☀️ Test successful - android, gonk, linux1, linux2, linux3, mac1, mac2, mac3
@bors-servo bors-servo merged commit 6eacb0c into servo:master Jul 16, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
This was referenced Jul 16, 2015
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-merge
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@pcwalton @metajack @bors-servo @jdm @highfive
You can’t perform that action at this time.