Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused has_children method. #6588

Merged
merged 1 commit into from Jul 14, 2015
Merged

Remove unused has_children method. #6588

merged 1 commit into from Jul 14, 2015
+0 −4

Conversation

@Ms2ger
Copy link
Contributor

Ms2ger commented Jul 10, 2015

Review on Reviewable
@Ms2ger
Remove unused has_children method.
Loading status checks…
928f843
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Jul 10, 2015

Critic review: https://critic.hoppipolla.co.uk/r/5513

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.
@pcwalton
Copy link
Contributor

pcwalton commented Jul 13, 2015

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Jul 13, 2015

📌 Commit 928f843 has been approved by pcwalton
@bors-servo
Copy link
Contributor

bors-servo commented Jul 13, 2015

⌛ Testing commit 928f843 with merge bc457c5...
bors-servo pushed a commit that referenced this pull request Jul 13, 2015
bors-servo
Auto merge of #6588 - Ms2ger:has_children, r=pcwalton
bc457c5 
Remove unused has_children method.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6588)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 13, 2015

💔 Test failed - mac3
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Jul 14, 2015

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 14, 2015

⚡ Previous build results for android, gonk, linux1, linux2, linux3, mac1, mac2 are reusable. Rebuilding only mac3...
@bors-servo
Copy link
Contributor

bors-servo commented Jul 14, 2015

💔 Test failed - mac3
@Ms2ger
Copy link
Contributor Author

Ms2ger commented Jul 14, 2015

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Jul 14, 2015

⌛ Testing commit 928f843 with merge c70d53c...
bors-servo pushed a commit that referenced this pull request Jul 14, 2015
bors-servo
Auto merge of #6588 - Ms2ger:has_children, r=pcwalton
Loading status checks…
c70d53c 
Remove unused has_children method.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6588)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 14, 2015

☀️ Test successful - android, gonk, linux1, linux2, linux3, mac1, mac2, mac3
@bors-servo bors-servo merged commit 928f843 into servo:master Jul 14, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Ms2ger Ms2ger deleted the Ms2ger:has_children branch Jul 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-awaiting-review
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Ms2ger @hoppipolla-critic-bot @pcwalton @bors-servo @highfive
You can’t perform that action at this time.