Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upcompositing: Make the constellation messages serializable. #6593
Conversation
hoppipolla-critic-bot
commented
Jul 11, 2015
|
Critic review: https://critic.hoppipolla.co.uk/r/5521 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
|
|
-S-awaiting-review +S-needs-code-changes Reviewed 33 of 33 files at r1. components/msg/Cargo.toml, line 37 [r1] (raw file): components/msg/Cargo.toml, line 41 [r1] (raw file): Comments from the review on Reviewable.io |
|
Fixed. r? @jdm Note that this is currently blocked on serde: serde-rs/serde#102 |
|
-S-awaiting-review +S-blocked-on-external Reviewed 21 of 21 files at r2. Comments from the review on Reviewable.io |
|
|
|
Rebased. Still blocked on @erickt reviewing serde-rs/serde#102 |
|
|
erickt
commented
Jul 16, 2015
|
@pcwalton: I merged in your PR. Do you need a release cut for this as well? |
|
-S-awaiting-review -S-blocked-on-external +S-needs-rebase Reviewed 21 of 21 files at r2, 19 of 19 files at r3. Comments from the review on Reviewable.io |
|
@bors-servo: r=jdm |
|
|
|
|
compositing: Make the constellation messages serializable. Same idea as before. This depends on: * servo/euclid#94 * hyperium/hyper#603 r? @jdm <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6593) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry Network failure |
|
|
|
OK, that's odd. A URL parsing test case no longer fails. Perhaps the fact that we serialize URLs via strings between the constellation and the rest of Servo has caused this? |
|
@bors-servo: r=jdm |
|
|
compositing: Make the constellation messages serializable. Same idea as before. This depends on: * servo/euclid#94 * hyperium/hyper#603 r? @jdm <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6593) <!-- Reviewable:end -->
This comment has been minimized.
This comment has been minimized.
|
It's a project build file: see http://doc.crates.io/manifest.html and https://github.com/toml-lang/toml |
pcwalton commentedJul 11, 2015
Same idea as before. This depends on:
r? @jdm