Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upscript: Split `Pipeline::create` into chrome process and content process parts. #6618
Conversation
hoppipolla-critic-bot
commented
Jul 14, 2015
|
Critic review: https://critic.hoppipolla.co.uk/r/5544 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
Reviewed 11 of 11 files at r1. Comments from the review on Reviewable.io |
|
@bors-servo: r+ |
|
|
…bergstrom script: Split `Pipeline::create` into chrome process and content process parts. This will make it easier to adapt to IPC. The trickiest part here was to make script tasks spawn new layout tasks directly instead of having the pipeline do it for them. The latter approach will not work in multiprocess mode, because layout and script must run in the same address space and the pipeline cannot inject tasks into another process. r? @larsbergstrom <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6618) <!-- Reviewable:end -->
Fix then r=me |
|
|
pcwalton
force-pushed the
pcwalton:content-process-code-shuffling
branch
from
4481509
to
401a3d8
|
@bors-servo: r=larsbergstrom |
|
|
…bergstrom script: Split `Pipeline::create` into chrome process and content process parts. This will make it easier to adapt to IPC. The trickiest part here was to make script tasks spawn new layout tasks directly instead of having the pipeline do it for them. The latter approach will not work in multiprocess mode, because layout and script must run in the same address space and the pipeline cannot inject tasks into another process. r? @larsbergstrom <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6618) <!-- Reviewable:end -->
|
|
process parts. This will make it easier to adapt to IPC. The trickiest part here was to make script tasks spawn new layout tasks directly instead of having the pipeline do it for them. The latter approach will not work in multiprocess mode, because layout and script must run in the same address space and the pipeline cannot inject tasks into another process.
|
|
iframe case instead of creating a new one. Fixes test timeouts.
pcwalton
force-pushed the
pcwalton:content-process-code-shuffling
branch
from
401a3d8
to
c2195c4
|
Should fix the timeouts. r? @larsbergstrom |
|
Reviewed 1 of 11 files at r1, 11 of 11 files at r2. Comments from the review on Reviewable.io |
all files reviewed at latest revision, all discussions resolved, all commit checks successful.
|
@bors-servo: r+ |
|
|
…bergstrom script: Split `Pipeline::create` into chrome process and content process parts. This will make it easier to adapt to IPC. The trickiest part here was to make script tasks spawn new layout tasks directly instead of having the pipeline do it for them. The latter approach will not work in multiprocess mode, because layout and script must run in the same address space and the pipeline cannot inject tasks into another process. r? @larsbergstrom <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6618) <!-- Reviewable:end -->
pcwalton commentedJul 14, 2015
This will make it easier to adapt to IPC.
The trickiest part here was to make script tasks spawn new layout tasks
directly instead of having the pipeline do it for them. The latter
approach will not work in multiprocess mode, because layout and script
must run in the same address space and the pipeline cannot inject tasks
into another process.
r? @larsbergstrom