Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove window field from domrectlist #6628

Merged
merged 1 commit into from
Jul 15, 2015

Conversation

michaelwu
Copy link
Contributor

Nothing uses this field AFAICT.

Review on Reviewable

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label Jul 15, 2015
@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/5551

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@jdm
Copy link
Member

jdm commented Jul 15, 2015

@bors-servo: r+

@bors-servo
Copy link
Contributor

📌 Commit c90be8e has been approved by jdm

@bors-servo
Copy link
Contributor

⌛ Testing commit c90be8e with merge c83500f...

bors-servo pushed a commit that referenced this pull request Jul 15, 2015
Remove window field from domrectlist

Nothing uses this field AFAICT.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6628)
<!-- Reviewable:end -->
@jdm jdm added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels Jul 15, 2015
@bors-servo
Copy link
Contributor

💔 Test failed - mac1

@jdm
Copy link
Member

jdm commented Jul 15, 2015

@bors-servo: r+

@larsbergstrom! Did the upgrade reset the max open files again?

@bors-servo
Copy link
Contributor

📌 Commit c90be8e has been approved by jdm

@Ms2ger
Copy link
Contributor

Ms2ger commented Jul 15, 2015

@bors-servo retry

@bors-servo
Copy link
Contributor

⌛ Testing commit c90be8e with merge b6b9508...

bors-servo pushed a commit that referenced this pull request Jul 15, 2015
Remove window field from domrectlist

Nothing uses this field AFAICT.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6628)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

☀️ Test successful - android, gonk, linux1, linux2, linux3, mac1, mac2, mac3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants