Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDon't crash when Firefox doesn't send autoMargins. #6637
Conversation
highfive
commented
Jul 15, 2015
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @Ms2ger (or someone else) soon. |
hoppipolla-critic-bot
commented
Jul 15, 2015
|
Critic review: https://critic.hoppipolla.co.uk/r/5563 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
Thanks @notriddle! Be sure to check the output of Reviewed 1 of 1 files at r1. components/devtools/actors/inspector.rs, line 462 [r1] (raw file):
We don't want to include any margin information if it's not requested. Comments from the review on Reviewable.io |
|
Looks great! Could you squash these three commits together, please? Reviewed 1 of 1 files at r3. Comments from the review on Reviewable.io |
|
It's squashed. |
|
@bors-servo: r+ |
|
|
Don't crash when Firefox doesn't send autoMargins.
Firefox Developer Tools doesn't always send autoMargins, as seen in this message:
{"type":"getLayout","node":"node14","to":"pageStyle9"}
So don't use unwrap.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6637)
<!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
|
|
Don't crash when Firefox doesn't send autoMargins.
Firefox Developer Tools doesn't always send autoMargins, as seen in this message:
{"type":"getLayout","node":"node14","to":"pageStyle9"}
So don't use unwrap.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6637)
<!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
notriddle commentedJul 15, 2015
Firefox Developer Tools doesn't always send autoMargins, as seen in this message:
So don't use unwrap.