Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ranges observe mutations on document #6639

Closed
wants to merge 7 commits into from

Don't do deep cloning for partially contained nodes (results in doubl…

…ed text)
  • Loading branch information
dzbarsky committed Jul 14, 2015
commit e83fd7a554aa851710e39bfd9d9a60e94c452ece
@@ -405,7 +405,7 @@ impl<'a> RangeMethods for &'a Range {
},
_ => {
// Step 14.1.
let clone = child.CloneNode(true);
let clone = child.CloneNode(false);
// Step 14.2.
try!(NodeCast::from_ref(fragment.r()).AppendChild(clone.r()));
// Step 14.3.
@@ -446,7 +446,7 @@ impl<'a> RangeMethods for &'a Range {
},
_ => {
// Step 17.1.
let clone = child.CloneNode(true);
let clone = child.CloneNode(false);
// Step 17.2.
try!(NodeCast::from_ref(fragment.r()).AppendChild(clone.r()));
// Step 17.3.

This file was deleted.

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.