Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gleam 0.1.3 + fix cargo.lock for cef/gonk #6642

Closed
wants to merge 1 commit into from
Closed

Conversation

@glennw
Copy link
Member

glennw commented Jul 15, 2015

Review on Reviewable

@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Jul 15, 2015

Critic review: https://critic.hoppipolla.co.uk/r/5569

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@glennw
Copy link
Member Author

glennw commented Jul 15, 2015

@bors-servo
Copy link
Contributor

bors-servo commented Jul 16, 2015

The latest upstream changes (presumably #6572) made this pull request unmergeable. Please resolve the merge conflicts.

@metajack
Copy link
Contributor

metajack commented Jul 16, 2015

r=me once you rebase

-S-awaiting-review +S-needs-rebase


Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from the review on Reviewable.io

@glennw glennw force-pushed the glennw:gleam0.1.3 branch from a66b8da to d2a72b4 Jul 16, 2015
@glennw
Copy link
Member Author

glennw commented Jul 16, 2015

@bors-servo r=metajack

@bors-servo
Copy link
Contributor

bors-servo commented Jul 16, 2015

📌 Commit d2a72b4 has been approved by metajack

@bors-servo
Copy link
Contributor

bors-servo commented Jul 16, 2015

Testing commit d2a72b4 with merge e4e9e83...

bors-servo pushed a commit that referenced this pull request Jul 16, 2015
gleam 0.1.3 + fix cargo.lock for cef/gonk



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6642)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jul 16, 2015

💔 Test failed - android

@jdm
Copy link
Member

jdm commented Jul 17, 2015

/home/servo/.cargo/registry/src/github.com-0a35038f75765ae4/gleam-0.1.3/src/gl.rs:124:9: 124:29 error: unresolved name `ffi::GenVertexArrays`
/home/servo/.cargo/registry/src/github.com-0a35038f75765ae4/gleam-0.1.3/src/gl.rs:124         ffi::GenVertexArrays(n, result.as_mut_ptr());
                                                                                              ^~~~~~~~~~~~~~~~~~~~
/home/servo/.cargo/registry/src/github.com-0a35038f75765ae4/gleam-0.1.3/src/gl.rs:132:9: 132:32 error: unresolved name `ffi::DeleteVertexArrays`
/home/servo/.cargo/registry/src/github.com-0a35038f75765ae4/gleam-0.1.3/src/gl.rs:132         ffi::DeleteVertexArrays(vertex_arrays.len() as GLsizei, vertex_arrays.as_ptr());
                                                                                              ^~~~~~~~~~~~~~~~~~~~~~~
/home/servo/.cargo/registry/src/github.com-0a35038f75765ae4/gleam-0.1.3/src/gl.rs:209:9: 209:29 error: unresolved name `ffi::BindVertexArray`
/home/servo/.cargo/registry/src/github.com-0a35038f75765ae4/gleam-0.1.3/src/gl.rs:209         ffi::BindVertexArray(vao);
                                                                                              ^~~~~~~~~~~~~~~~~~~~
/home/servo/.cargo/registry/src/github.com-0a35038f75765ae4/gleam-0.1.3/src/gl.rs:471:9: 471:33 error: unresolved name `ffi::GetFragDataLocation`
/home/servo/.cargo/registry/src/github.com-0a35038f75765ae4/gleam-0.1.3/src/gl.rs:471         ffi::GetFragDataLocation(program, CString::new(name).unwrap().as_ptr())
                                                                                              ^~~~~~~~~~~~~~~~~~~~~~~~
@glennw
Copy link
Member Author

glennw commented Jul 20, 2015

Will close this and open a new one for gleam 0.1.4.

@glennw glennw closed this Jul 20, 2015
@glennw glennw deleted the glennw:gleam0.1.3 branch Jul 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.