Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMake tidy check for "*" in toml files #6648
Conversation
hoppipolla-critic-bot
commented
Jul 16, 2015
|
Critic review: https://critic.hoppipolla.co.uk/r/5576 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
You guys are gonna have to guide me through updating the versions |
|
@boghison You can use the Cargo.lock file as a guide - take the current A.B.C version for each matching package, and replace the "*" with "A.B". |
|
Hmm, I am getting these errors: |
|
Oops, never mind ^^, I got the bitflags version wrong |
|
|
|
-S-awaiting-review +S-needs-code-changes Reviewed 2 of 2 files at r1, 23 of 23 files at r2. components/layout/Cargo.toml, line 66 [r2] (raw file): python/tidy.py, line 153 [r2] (raw file): python/tidy.py, line 162 [r2] (raw file): Comments from the review on Reviewable.io |
|
@jdm I've edited the files. |
|
-S-awaiting-review +S-needs-code-changes Reviewed 2 of 2 files at r3. Comments from the review on Reviewable.io |
|
@bors-servo: r+ Review status: Comments from the review on Reviewable.io |
|
|
Make tidy check for "*" in toml files This checks every .toml file for an asterisk and prints an error if found. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6648) <!-- Reviewable:end -->
boghison commentedJul 16, 2015
This checks every .toml file for an asterisk and prints an error if found.